| Stang | |
| Aug 11 2022, 1:01 PM |
| F35526130: Empty Space IPInfo_PASS.png | |
| Sep 20 2022, 6:15 PM |
| F35514974: image.png | |
| Sep 9 2022, 2:51 PM |
| F35514970: image.png | |
| Sep 9 2022, 2:51 PM |
| F35507513: infobox_height_T315005.png | |
| Sep 2 2022, 12:51 PM |
| F35466760: height_reserved_enable_form.png | |
| Aug 17 2022, 12:33 PM |
| F35423635: image.png | |
| Aug 11 2022, 1:01 PM |
Example: https://www.wikidata.org/wiki/Special:Contributions/1.1.1.1
.ext-ipinfo-panel-layout > :not(.mw-collapsed) { min-height: 20em; }
AC
I don't know if we can tell what the correct height should be before making the request to the IP Information API.
Another example, although slightly less noticeable:
@Tchanders , @TThoabala , it seems to have been solved while working on this task https://phabricator.wikimedia.org/T314394. How do i go about this?Should i move this to code review?Thanks
@Cyndymediawiksim I'm still seeing the problem in this task, even with the patch from T314394 applied. E.g. I go to Special:Contributions/<some IP that has no edits>, and I see the same as the screenshot in this task's description, with lots of space below the error message.
However, I agree with @dom_walden that it may not be possible to fix this. What's happening:
We set the height of the infobox before step (3), to avoid a jump during (4). At that point we do not know whether we will get full IP information or an error, so we set it to the height that is needed to contain the full information.
@Prtksxna Do you think it is acceptable to close this, or should we do something else here?
Thanks for the explanation! Is it possible to set the height of the box to match its content after step 4? It might introduce another jump (the third one?) but since this an error case its probably okay.
We could set a different min-height whenever the infobox contains the error message. (In theory the error message could be different lengths, but we could guess and make it closer.)
Change 828491 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):
[mediawiki/extensions/IPInfo@master] Remove empty space when no edit from an IP Address
Change 828491 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Remove empty space when no edit from an IP Address
@Cyndymediawiksim The height of the infobox without an error is slightly less now:
On Vector 2022:
Before: 308.017px
After: 298.883px
I notice that the new CSS also matches in the case when there is no error.
Change 829842 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/extensions/IPInfo@master] Resize infobox if no revisions exist
@Prtksxna @dom_walden After discussing with @Cyndymediawiksim, we're going to take a different approach.
The new patch fixes only the problem in the task description: when the IP address has no revisions, and so no API call is ever made. (In this situation, keeping the infobox shorter does not cause an extra jump when the error is appended.)
It doesn't fix the situation when the API returns an error, because that would cause an extra jump. Since it is a rarer occurrence, I think it is less likely to be reported as a bug.
@Prtksxna Is this OK? We could make a simple update to the patch to fix the second situation too, but I'm wary of reintroducing the jump since we don't need to in order to fix the problem that was reported...
Wanted to confirm that the box will keep its original size (bigger) after the error message has loaded. Like in F35423635?
Not for that particular error. That error occurs before the API call is made, so it will display like this (and with no jump):
But when the API returns an error, we would see (which avoids a jump when the infobox shrinks):
That second case should be rare from the UI though - in theory the user shouldn't be able to get there if they don't have permission, the revision doesn't exist, they're blocked, etc.
Change 829842 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Resize infobox if no revisions exist
Dom and I validated that the empty space does not exist in IPInfo in Beta as seen in the screenshot. We also validated that the empty space does not exist when a user does not have rights.
We did have a question for @Tchanders regarding your comment on Fri, Sep 9, 7:51 AM. What were the steps did you take to create that screenshot error with "You do not have permission to perform the action"? Does that need to be tested?
We did have a question for @Tchanders regarding your comment on Fri, Sep 9, 7:51 AM. What were the steps did you take to create that screenshot error with "You do not have permission to perform the action"? Does that need to be tested?
Ah, good question. It wasn't a real case - I forced the API to return the error by changing the code - so no extra testing needed. Thank you both!
Ok sounds good, we'll mark it as done!
We did have a question for @Tchanders regarding your comment on Fri, Sep 9, 7:51 AM. What were the steps did you take to create that screenshot error with "You do not have permission to perform the action"? Does that need to be tested?
Ah, good question. It wasn't a real case - I forced the API to return the error by changing the code - so no extra testing needed. Thank you both!