Maniphest T315027

Reduce the performance cost of object validation
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	ori
	Aug 11 2022, 4:16 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

We observed (in T310093#8124847) that object validation code accounts for over 60% of function call latency.

Things to investigate:

Can we get by with less validation?
Can we make validation more efficient?

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Use heuristic type-checking instead of validation when resolving.	repos/abstract-wiki/wikifunctions/function-orchestrator!6	jforrester	gerrit-823187	main

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T315027 Reduce the performance cost of object validation
		Open		None	T315026 Discuss Not Running Static Validation
		Resolved		• maryyang	T315028 Consider Removing mutex/async from Schema
		Resolved		• maryyang	T296841 Consider Locking Validators When `validateStatus` Is Called

Event Timeline

ori created this task.Aug 11 2022, 4:16 PM

cmassaro added a subtask: T315026: Discuss Not Running Static Validation.Aug 11 2022, 4:25 PM

Jdforrester-WMF added projects: function-orchestrator, Performance Issue.Aug 11 2022, 4:39 PM

Jdforrester-WMF subscribed.

cmassaro added a subtask: T315028: Consider Removing mutex/async from Schema.Aug 11 2022, 4:40 PM

• AAssaf subscribed.Aug 16 2022, 4:46 PM

DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Aug 16 2022, 6:52 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 21 2022, 8:24 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).

Jdforrester-WMF closed subtask T315028: Consider Removing mutex/async from Schema as Resolved.Nov 21 2022, 8:37 PM

jforrester updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/6

Draft: Use heuristic type-checking instead of validation when resolving.

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/6

Use heuristic type-checking instead of validation when resolving.

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Upcoming Epics on the Abstract Wikipedia team board.Jun 5 2024, 4:54 PM

Jdforrester-WMF moved this task from Upcoming Epics to No current plans / External on the Abstract Wikipedia team board.Mar 11 2026, 8:27 PM