When I turn WikimediaDebug on, I want it to stay on till I turn it off... Not turn itself off somewhat arbitrarily.
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| v3.1.0: Update changelog | performance/WikimediaDebug | master | +13 -1 | |
| Add debug instrumentation | performance/WikimediaDebug | master | +16 -2 |
Related Objects
Event Timeline
The extension turns off after 15min to avoid staying on an mwdebug all day, especially for people using it mainly stage deployments or verify changes. E.g. volunteer requesting config change.
The issue with staying on it is mainly that:
- It can be verbosely logging your activity in great detail, which is quite personal.
- Even if you use it correctly, when someone else isn't this muddles the mwdebug Logstash dashboard for when you're using it. Similarly, it can polute the XHGui feed with continues unintentional profiles.
- For XHGui in particular, there is also a space question given we prefer to keep permalinks working there, and thus there is an assumption of limited ingestion and thus no need for gargage collection or expiring.
- Another issue can be that when using mwdebug to ad-hoc change code or test something, this will affect previous users and in particular can e.g. end up modifying their account or log additional personal details of their actions instead of yours.
The bug I describe above may be partly due to T395190: WikimediaBackend ignores the last change to "backend" dropdown, which is a separate more narrow issue. I'm fixing that first.
Change #1149825 had a related patch set uploaded (by Krinkle; author: Krinkle):
[performance/WikimediaDebug@master] Add debug instrumentation
Change #1149825 merged by jenkins-bot:
[performance/WikimediaDebug@master] Add debug instrumentation
Change #1151696 had a related patch set uploaded (by Hashar; author: Hashar):
[performance/WikimediaDebug@master] v3.1.0: Update changelog
Change #1151696 merged by jenkins-bot:
[performance/WikimediaDebug@master] v3.1.0: Update changelog
Mentioned in SAL (#wikimedia-releng) [2025-05-29T22:11:58Z] <bd808> Submitted WikimediaDebug v3.1.0 to Chrome Web Store for review (T395190, T315111)
Mentioned in SAL (#wikimedia-releng) [2025-05-29T22:18:08Z] <bd808> Submitted WikimediaDebug v3.1.0 to addons.mozilla.org for review (T395190, T315111)
With the rollout of PHP 8.3... Especially in these very early stages, I'd love to be able to stick my activity onto the PHP 8.3 hosts, and frankly leave it there for the near term future.