Page MenuHomePhabricator

Handle missing or invalid marker icons
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently the thumbnail is empty when there are missing marker icons, the preview does work however (example).
Error message: "Marker symbol \"american-football\" is invalid."

Static thumbnail on wiki page:

Screenshot from 2022-08-15 14-46-53.png (558×757 px, 9 KB)

Dynamic page preview:

Screenshot from 2022-08-15 15-04-24.png (682×1 px, 315 KB)

  • Also if there is either a number or uppercase letters in the icon name, such as "park-alt1" or "bank-JP", this happens:

Screenshot from 2022-08-12 15-31-54.png (237×1 px, 36 KB)

Event Timeline

lilients_WMDE renamed this task from Handle missing marker icons to Handle missing or invalid marker icons.Aug 15 2022, 1:28 PM
lilients_WMDE updated the task description. (Show Details)

Change 823599 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] Relax validation regex to allow icon names like "bank-JP" and "park-alt1"

https://gerrit.wikimedia.org/r/823599

awight updated the task description. (Show Details)

Change 823599 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Relax validation regex to allow icon names like "bank-JP" and "park-alt1"

https://gerrit.wikimedia.org/r/823599

WMDE-Fisch set the point value for this task to 2.