Page MenuHomePhabricator

Rename RequestContext::getLang to getLanguage
Closed, ResolvedPublic

Description

Rename RequestContext::getLang to getLanguage. The truncated method name doesn't fit with the other methods and the full name is only four letters longer :)


Version: 1.20.x
Severity: enhancement

Details

Reference
bz29524

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:29 PM
bzimport set Reference to bz29524.

john wrote:

r103817, but they'll likely be fallout from this. Keep an eye on it for a bit.

RequestContext::getLang() was added in 1.18. So either we also rename it there, or stick with the shorter name (take it as frozen).

demon added a comment.Nov 21 2011, 9:37 PM

(In reply to comment #2)

RequestContext::getLang() was added in 1.18. So either we also rename it there,
or stick with the shorter name (take it as frozen).

Please, let's rename it there too.

john wrote:

Yeah I'm all for back-porting this. I'll update usage in extensions soon.

There's also a setLang() method which should presumably be changed to match the getter, too.

john wrote:

Apparently I did that r104015

Closing as no issues have arisen.