Page MenuHomePhabricator

Special:Search - Update interwiki widget sister project icons
Closed, ResolvedPublic


  • Update sister projects icons. These are the new black and white icons added to design system. All the icons can be found at the bottom of this icon list. - Blocked by T314661

Event Timeline

@Volker_E I was asked to do this task and I wanted to reach out to make sure I do it correctly and or wait longer to make sure things are done right.

From what I can see, the Icons are currently defined in CODE by fetching the favicon of the sister's project sites (/mediawiki/includes/search/searchwidgets/InterwikiSearchResultSetWidget.php), From what I can see, this ticket could be achieved with one of the following 2 options:

  • We add the ICONS to MediaWiki and continue to implement the work on the Backend (just change the link with the SVG endpoint).
  • We actually add Vue on the search page and add the icons correctly using it!

I think the first solution may be ok in this case as we are just loading project svg, but it feels like a hack more than a good implementation, but the second seems like a lot of work for what we have to achieve. Would you please advice what you suggest to be the best option? I ma happy to ask internally in the team, but I thought to reach out as you are heavily involved with the icons and its adaptation and wanted to get your opinion

Found a solution. I can use the OOUI icons as the above mentioned set of icons have also been added to the OOUI widget

Change 900640 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/core@master] Special:Search - Update interwiki sister icons

Change 917871 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[operations/mediawiki-config@master] Add $wgInterwikiLogoOverride

Change 900640 merged by jenkins-bot:

[mediawiki/core@master] Special:Search - Update interwiki sister icons

Change 917871 merged by jenkins-bot:

[operations/mediawiki-config@master] Add $wgInterwikiLogoOverride

Mentioned in SAL (#wikimedia-operations) [2023-06-01T07:08:58Z] <mlitn@deploy1002> Started scap: Backport for [[gerrit:917871|Add $wgInterwikiLogoOverride (T315269)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-01T07:29:39Z] <mlitn@deploy1002> mlitn: Backport for [[gerrit:917871|Add $wgInterwikiLogoOverride (T315269)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-01T07:42:01Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:917871|Add $wgInterwikiLogoOverride (T315269)]] (duration: 33m 02s)

Checked in wmf.11: commons icon displayed black-and -white; other icons displayed as per figma link in the task description \

Screen Shot 2023-06-02 at 4.30.52 PM.png (424×1 px, 194 KB)
Screen Shot 2023-06-05 at 3.07.55 PM.png (956×720 px, 695 KB)

Screen Shot 2023-06-05 at 2.52.08 PM.png (698×1 px, 82 KB)