Page MenuHomePhabricator

Deleting a function name alias label stores a "null" in the ZObject Viewer
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):
Go to the fallback editor for an existing function.
Add a couple of alias labels for the function name (in the labels box at the top).
Delete one of the alias labels (not the last).

What happens?:
The zObject viewer updates but stores a "null" value for the deleted label instead of just removing it.

"Z2K4": {
        "Z1K1": "Z32",
        "Z32K1": [
            "Z31",
            {
                "Z1K1": "Z31",
                "Z31K1": "Z1002",
                "Z31K2": [
                    "Z6",
                    "my night memories",
                    null,
                    "sleepy saver"
                ]
            }
        ]

What should have happened instead?:
The item is just removed from the list

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 824205 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Function editor: Correctly update the zObject when deleting an alias label.

https://gerrit.wikimedia.org/r/824205

Change 824205 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Function editor: Correctly update the zObject when deleting an alias label.

https://gerrit.wikimedia.org/r/824205

Change 824205 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Function editor: Correctly update the zObject when deleting an alias label.

https://gerrit.wikimedia.org/r/824205

Mahir256 renamed this task from Deleting a function name alias label stores a "null" in the ZObject Viewer. to Deleting a function name alias label stores a "null" in the ZObject Viewer.Aug 19 2022, 5:11 PM