Page MenuHomePhabricator

Replace ForeignResourceManager::parseBasicYaml() with symfony/yaml call
Closed, ResolvedPublic

Description

	/**
	 * Basic YAML parser.
	 *
	 * Supports only string or object values, and 2 spaces indentation.
	 *
	 * @todo Just ship symfony/yaml.
	 * @param string $input
	 * @return array
	 */
	private function parseBasicYaml( $input ) {

Since rMW120ef51cbf76: SettingsBuilder: Add YAML file format., symfony/yaml has been included by default in MW core's composer.json require. We should be able to replace this custom Yaml parser with a call to symfony/yaml now

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 823615 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] ForeignResourceManager: Replace custom yaml parser with Syfony Yaml parser

https://gerrit.wikimedia.org/r/823615

I think this may require a cache invalidation. There's no version number though...

Change 823615 merged by jenkins-bot:

[mediawiki/core@master] ForeignResourceManager: Replace custom yaml parser with Symfony Yaml parser

https://gerrit.wikimedia.org/r/823615

Reedy claimed this task.