Page MenuHomePhabricator

wikimedia/promise-polyfill repo missing from github, referenced in foreign-resources.yaml
Closed, ResolvedPublic

Description

Running php maintenance/manageForeignResources.php update gives:

Error: Failed to download resource at https://raw.githubusercontent.com/wikimedia/promise-polyfill/9bafe45598e69e4215757dc874b99629d0dfea0d/dist/polyfill.js

Which is indeed a 404...

Possibly wrong since rMWe9f4e775c84e: resources: Add license information for promise-polyfill ?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Well, the whole repo doesn't exist, not just the hash...

Reedy renamed this task from wikimedia/promise-polyfill dist/polyfill.js commit hash seems to be wrong... to wikimedia/promise-polyfill repo missing from github, referenced in foreign-resources.yaml.Aug 16 2022, 1:48 PM
Reedy added a project: Wikimedia-GitHub.

The foreign-resources.yaml file contains:

promise-polyfill:
  type: multi-file
  files:
    promise-polyfill.js:
      # src: https://raw.githubusercontent.com/taylorhakes/promise-polyfill/8.1.3/dist/polyfill.js
      src: https://raw.githubusercontent.com/wikimedia/promise-polyfill/9bafe45598e69e4215757dc874b99629d0dfea0d/dist/polyfill.js

The "temporary" override has not been needed for some time as upstream merged out patch. Some years later I probably deleted our fork when cleaning up a list of GitHub repos that were marked as "not Gerrit mirrors and likely source repos", and noticed that the fork was 0 commits ahead and had no unmerged branches.

The correct upstream URL can be found in this unmerged patch which fixes the issue:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/776350/2/resources/lib/foreign-resources.yaml

Change 823756 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] resources: Update taylorhakes/promise-polyfill from 8.1.3 (forked) to 8.2.2

https://gerrit.wikimedia.org/r/823756

Krinkle triaged this task as High priority.
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.

Change 823756 merged by jenkins-bot:

[mediawiki/core@master] resources: Update taylorhakes/promise-polyfill to upstream URL

https://gerrit.wikimedia.org/r/823756