Page MenuHomePhabricator

Outstanding updates to styling of messages that show up above search results
Closed, ResolvedPublic

Description

This ticket is a follow up to T307464

Outstanding AC

  • Spacing and padding update as mentioned in this comment
.mw-search-form-wrapper { 
   margin-bottom: 1.4em;
}

.mw-search-results {
    margin: 2.4em 0 0 0;
}

.searchdidyoumean {
   margin-bottom: 0.8em;
}
  • Message 2: Add <br> to search-rewritten.
  • OPTIONAL Message 2: Smaller font size for second line.

Update Aug 24 2022: We will no longer be splitting the message into two lines due to challenges with updating the i18n.

New requirements

  • Message 2: Unlink the search term for which results not found as discussed in this comment. Check with search team to make sure there was no specific reason to have it linked.

Event Timeline

Sneha renamed this task from Update styling of messages that show up above search results to Outstanding updates to styling of messages that show up above search results.Aug 16 2022, 2:18 PM
Sneha updated the task description. (Show Details)

Change 824123 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/core@master] Special:Search dyk messaging and padding tweaks.

https://gerrit.wikimedia.org/r/824123

Testing notes (to check after the fix):

  • Message 2 - the red link for a non-existing article should be displayed.

Screen Shot 2022-08-24 at 6.01.09 PM.png (1×3 px, 544 KB)

CBogen subscribed.

The first AC about spacing was already handled in https://phabricator.wikimedia.org/T307467

The tickets are about different sets of messages, did T307467 update it for all messages or just "article does not exist" messages?

Just a clarification on the margin requirement after a conversation I had with Sneha:

  • Top margin-top: 24px
  • Bottom margin: 32px
  • If there is more than one message, the margin between the messages should be 12px
NOTE: Some messages are rendered outside the SearchBox, some are within it. See figma design and https://phabricator.wikimedia.org/T307467 for all the possible iterations of messages.

Change 824123 merged by jenkins-bot:

[mediawiki/core@master] WIP Special:Search dyk messaging and padding tweaks.

https://gerrit.wikimedia.org/r/824123

Checked in wmf.6 enwiki - no issues were found:
Message 1: "Did you mean"

wmf.23mockupwmf.6
Screen Shot 2022-08-11 at 4.48.00 PM.png (767×1 px, 215 KB)
Screen Shot 2022-08-11 at 4.49.35 PM.png (767×1 px, 188 KB)
{F35605014}

Message 2: "Showing results ..."

wmf.23mockupwmf.6
Screen Shot 2022-08-11 at 4.57.35 PM.png (682×1 px, 160 KB)
Screen Shot 2022-08-11 at 4.57.59 PM.png (610×1 px, 214 KB)
{F35605028}

Message 3: "There is a page named ..." - full match

wmf.23mockupwmf.6
Screen Shot 2022-08-11 at 5.03.11 PM.png (794×1 px, 227 KB)
Screen Shot 2022-08-11 at 5.03.35 PM.png (588×1 px, 195 KB)
Screen Shot 2022-10-20 at 11.06.11 AM.png (1×1 px, 313 KB)

Message 3: "There is a page named ..." - partial match

wmf.23wmf.6
Screen Shot 2022-08-11 at 5.18.59 PM.png (578×1 px, 83 KB)
Screen Shot 2022-10-20 at 11.21.11 AM.png (768×1 px, 90 KB)

Test wiki on Patch demo by Seddon using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/112ae8d6dd/w/