Outstanding appearance update of "Sister project widgets" on Special:Search
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sneha
	Aug 16 2022, 2:25 PM

Description

This ticket is a follow up to T307468

Outstanding AC

Add the missing separator line on mobile between search results and inter wiki links

Special_Search (19).png (800×360 px, 53 KB)

Mobile: Sister projects do not align with search results on the left margin.
Mobile: Spacing between title and links as shown in the image below needs to be adjusted to meet the spec

Screen Shot 2022-08-16 at 11.00.07 AM.png (1×664 px, 180 KB)

Desktop: padding needs to be adjusted in the areas indicated in the image below. They need to be reduced a little.

Screen Shot 2022-08-16 at 11.33.10 AM.png (436×722 px, 69 KB)

Mobile only: Show sister projects below the results only on the first page. Currently it is repeated on all pages.

Link to Figma

Missing black and white icons covered in T315269

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+41 -9	Suppress interwiki on search offset and iw css tweaks for special search

Customize query in gerrit

Related Objects

Mentioned In: T329110: [M] [wmf.21-regression] Mobile: Sister projects do not align with search results on the left margin.
T307468: [M] Appearance update of "Sister project widgets" on Special:Search
Mentioned Here: T315269: Special:Search - Update interwiki widget sister project icons
T307468: [M] Appearance update of "Sister project widgets" on Special:Search

Event Timeline

Sneha created this task.Aug 16 2022, 2:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2022, 2:25 PM

Sneha updated the task description. (Show Details)Aug 16 2022, 2:25 PM

Sneha updated the task description. (Show Details)

Sneha updated the task description. (Show Details)Aug 16 2022, 3:36 PM

CBogen updated the task description. (Show Details)Aug 16 2022, 3:41 PM

Sneha updated the task description. (Show Details)Aug 16 2022, 4:49 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Aug 16 2022, 5:32 PM

CBogen moved this task from Incoming to Ready for Development on the Structured-Data-Backlog (Current Work) board.

CBogen mentioned this in T307468: [M] Appearance update of "Sister project widgets" on Special:Search.Aug 18 2022, 2:40 PM

CBogen added a project: SDAW-Search-Improvements (Milestone 1: CSS changes to all wikis).Aug 25 2022, 12:35 PM

Seddon claimed this task.Aug 30 2022, 1:27 PM

Seddon moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Aug 30 2022, 1:30 PM

Change 828665 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/core@master] Suppress interwiki on search offset and iw css tweaks for special search

https://gerrit.wikimedia.org/r/828665

gerritbot added a project: Patch-For-Review.Sep 1 2022, 1:09 AM

Seddon moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Sep 4 2022, 3:53 AM

Test wiki created on Patch demo by Seddon using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/b445d75bf7/w

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Sep 13 2022, 8:58 AM

Change 828665 merged by jenkins-bot:

[mediawiki/core@master] Suppress interwiki on search offset and iw css tweaks for special search

https://gerrit.wikimedia.org/r/828665

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2022, 9:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 13 2022, 10:00 AM

Etonkovidova updated the task description. (Show Details)Sep 23 2022, 12:14 AM

Checked in wmf.2 - all specs seem to be in place:

Screen Shot 2022-09-22 at 5.11.05 PM.png (1×676 px, 189 KB)

Etonkovidova mentioned this in T329110: [M] [wmf.21-regression] Mobile: Sister projects do not align with search results on the left margin..Feb 7 2023, 7:54 PM

	F35529173: Screen Shot 2022-09-22 at 5.11.05 PM.png
	Sep 23 2022, 12:16 AM

	F35461707: Screen Shot 2022-08-16 at 11.33.10 AM.png
	Aug 16 2022, 3:36 PM

	F35461477: Screen Shot 2022-08-16 at 11.00.07 AM.png
	Aug 16 2022, 3:36 PM

Outstanding appearance update of "Sister project widgets" on Special:SearchClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Outstanding appearance update of "Sister project widgets" on Special:Search
Closed, ResolvedPublic
Actions