Page MenuHomePhabricator
Create Task
Maniphest T315353

Create database tables for permalinks in production wikis, and enable the feature
Open, Needs TriagePublic
Actions

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT314973 Improve Topic Subscription support for discussions that are merged, moved, or deleted
 OpenNoneT315050 Enable people to visit the page the discussion they were subscribed to has been moved to
 OpenNoneT318449 [Tracking] Improve the sharing of MediaWiki content
 OpenNoneT318446 [Tracking] Improve sharing link functionality of pages
 OpenNoneT315507 Introduce support for topic and comment permanent links within the Android and iOS apps
 OpenNoneT349353 Expose comment/topic permanent links on Special:Contributions
 OpenNoneT265269 Assist with linking to other comments within the Reply Tool
 OpenNoneT302011 [Release Ticket] Introduce permalinks on wikitext talk pages
 OpenmatmarexT315353 Create database tables for permalinks in production wikis, and enable the feature
 ResolvedmatmarexT296801 Introduce a data structure for tracking talk page comments
 ResolvedmatmarexT303295 DBA review: data structure for storing permalinks
 ResolvedPRODUCTION ERRORmatmarexT317236 Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname'
 ResolvedPRODUCTION ERRORmatmarexT317237 Wikimedia\Rdbms\DBUnexpectedError: Cannot execute Wikimedia\Rdbms\Database::rollback critical section while session state is out of sync
 ResolvedmatmarexT321121 When storing new permalinks data, update existing rows if possible rather than insert+delete
 ResolvedPRODUCTION ERRORmatmarexT317238 Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback')
 ResolvedLadsgroupT321360 Wipe permalinks data from the short-lived deployment
 ResolvedmatmarexT322701 Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry '…' for key 'itid_itemid' / 'it_itemname'
 ResolvedmatmarexT323079 "Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`"
 ResolvedmatmarexT323080 "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`"
 ResolvedmatmarexT334258 DiscussionTools can overload the database if DiscussionToolsEnablePermalinksBackend is enabled without running the persistRevisionThreadItems maintenance script
 ResolvedmatmarexT339882 Bad rows in discussiontools_item_pages, discussiontools_item_revisions with itp_items_id, itr_itemid_id, itr_items_id equal to 0
 ResolvedPRODUCTION ERRORmatmarexT341811 DBQueryError: "Duplicate entry … for key 'itp_items_id_page_id'" in "INSERT INTO `discussiontools_item_pages`"
 StalledmatmarexT315510 Start maintenance script to backfill talk page comment database
 ResolvedmatmarexT316548 DiscussionTools' maintenance scripts cannot be executed in Wikimedia production
 InvalidmatmarexT316915 It's 2022 and we still can't use Parsoid in production
 ResolvedPRODUCTION ERRORmatmarexT315383 MWException: Error contacting the Parsoid/RESTBase server (HTTP 404) from DiscussionTools (on closed wikis)
 ResolvedmatmarexT315688 MWException: Error contacting the Parsoid/RESTBase server (HTTP 404) from DiscussionTools (on open wikis) – permalinks unavailable for some edits
 ResolvedmatmarexT315689 MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): (no message) from DiscussionTools (on private wikis) – permalinks unavailable
 ResolvedmatmarexT316914 MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): Rerenders for this article are blacklisted in the config from DiscussionTools – permalinks unavailable for some pages
 ResolvedmatmarexT329627 Optimize permalinks maintenance script to avoid listing non-discussion pages
 ResolvedmatmarexT351732 Debug memory leak in maintenance script
 ResolvedSecuritymatmarexT356884 Specific fr.wp page is very slow to parse

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
matmarex added a comment.EditedSep 7 2022, 8:46 PM

The change was reverted in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/830600 after it caused some database errors: https://logstash.wikimedia.org/goto/97f0855fcb33135806cc59c31da20cf7

image.png (236×3 px, 25 KB)

Filed as T317236, T317237.

matmarex mentioned this in T317236: Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname'.Sep 7 2022, 8:47 PM
matmarex mentioned this in T317237: Wikimedia\Rdbms\DBUnexpectedError: Cannot execute Wikimedia\Rdbms\Database::rollback critical section while session state is out of sync.
JJMC89 added subtasks: T317236: Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname', T317237: Wikimedia\Rdbms\DBUnexpectedError: Cannot execute Wikimedia\Rdbms\Database::rollback critical section while session state is out of sync.Sep 7 2022, 8:50 PM
Ladsgroup subscribed.Sep 9 2022, 10:53 AM

Does the deletion work correctly? I'm seeing this:

wikiadmin@10.64.16.208(testwiki)> select * from discussiontools_item_revisions  order by itr_id desc limit 50;
+--------+---------------+-----------------+--------------+---------------+---------------------+-----------+------------------+
| itr_id | itr_itemid_id | itr_revision_id | itr_items_id | itr_parent_id | itr_transcludedfrom | itr_level | itr_headinglevel |
+--------+---------------+-----------------+--------------+---------------+---------------------+-----------+------------------+
|  46963 |         25262 |          542560 |        18019 |         46962 |                NULL |         4 |             NULL |
|  46962 |         25261 |          542560 |        18019 |         46961 |                NULL |         3 |             NULL |
|  46961 |         25260 |          542560 |        18019 |         46960 |                NULL |         2 |             NULL |
|  46960 |         25259 |          542560 |        18018 |         46959 |                NULL |         1 |             NULL |
|  46959 |         25258 |          542560 |        18017 |          NULL |                NULL |         0 |                2 |
|  46954 |         25260 |          542558 |        18019 |         46953 |                NULL |         2 |             NULL |
|  46951 |         25259 |          542557 |        18018 |         46950 |                NULL |         1 |             NULL |
|  46950 |         25258 |          542557 |        18017 |          NULL |                NULL |         0 |                2 |

https://test.wikipedia.org/w/index.php?title=Talk:Rivers_in_mexico/en&action=history

I'm slightly worried we actually might run out of auto increment value if it inserts and deletes this much (and generally it puts pressure on replication with this number of writes). Let me think a bit.

Having DT persistence for page makes sense and is good and easy but I'm not sure I understand problem space of persistence on revision.

Ladsgroup added a comment.Sep 9 2022, 11:06 AM

I think at least it shouldn't insert + delete. Go with update as much as possible (I'm seeing it for page but not for revision)

matmarex added a comment.Sep 10 2022, 7:31 PM

@Ladsgroup Can you explain what about these numbers is concerning? Note that this is after running the maintenance script on testwiki (T315510#8200829), and that the largest numbers in itr_revision_id are just keys to the revision table. What I'm seeing here is 46963 discussion items encountered after processing 7761 discussion pages, which seems entirely reasonable.

We should try using 'update' if you think that would help.

Ladsgroup added a comment.Sep 12 2022, 8:33 AM
In T315353#8227020, @matmarex wrote:

@Ladsgroup Can you explain what about these numbers is concerning? Note that this is after running the maintenance script on testwiki (T315510#8200829), and that the largest numbers in itr_revision_id are just keys to the revision table. What I'm seeing here is 46963 discussion items encountered after processing 7761 discussion pages, which seems entirely reasonable.

But the maint script doesn't run for revisions, I assume it'll be much higher number if it were to run on revisions. In other words, It looks like after edits, it's growing really fast.

For example, in this case, in a small discussion page with three comments, three edits led to a jump of 13 in itr_id, in a large discussion page, each edit would a cause an even larger jump. On top of that, deletion and insertion like this has larger write overhead in replication.

We should try using 'update' if you think that would help.

It will help here. Also, I suggest splitting the transaction into smaller pieces.

• ppelberg closed subtask T317237: Wikimedia\Rdbms\DBUnexpectedError: Cannot execute Wikimedia\Rdbms\Database::rollback critical section while session state is out of sync as Resolved.Oct 18 2022, 12:30 AM
• ppelberg closed subtask T317236: Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry (…) for key 'it_itemname' as Resolved.
matmarex mentioned this in T321121: When storing new permalinks data, update existing rows if possible rather than insert+delete.Oct 18 2022, 7:15 PM
matmarex added a subtask: T321121: When storing new permalinks data, update existing rows if possible rather than insert+delete.
TheresNoTime mentioned this in T317238: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback').Oct 20 2022, 4:02 PM
matmarex added a subtask: T317238: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback').Oct 20 2022, 4:34 PM
matmarex closed subtask T317238: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback') as Resolved.
Ladsgroup closed subtask T321360: Wipe permalinks data from the short-lived deployment as Resolved.Oct 26 2022, 1:16 PM
• ppelberg closed subtask T321121: When storing new permalinks data, update existing rows if possible rather than insert+delete as Resolved.Nov 4 2022, 11:30 PM
gerritbot added a comment.Nov 7 2022, 8:20 PM

Change 854097 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group0 wikis

https://gerrit.wikimedia.org/r/854097

gerritbot added a comment.Nov 7 2022, 9:14 PM

Change 854097 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group0 wikis

https://gerrit.wikimedia.org/r/854097

Stashbot added a comment.Nov 7 2022, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:17:34Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:854097|Enable wgDiscussionToolsEnablePermalinksBackend on group0 wikis (T315353)]]

Stashbot added a comment.Nov 7 2022, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:17:54Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:854097|Enable wgDiscussionToolsEnablePermalinksBackend on group0 wikis (T315353)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Nov 7 2022, 9:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:23:22Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:854097|Enable wgDiscussionToolsEnablePermalinksBackend on group0 wikis (T315353)]] (duration: 05m 47s)

gerritbot added a comment.Nov 8 2022, 8:00 PM

Change 854606 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis

https://gerrit.wikimedia.org/r/854606

gerritbot added a comment.Nov 8 2022, 9:35 PM

Change 854606 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis

https://gerrit.wikimedia.org/r/854606

Stashbot added a comment.Nov 8 2022, 9:35 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-08T21:35:15Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:854606|Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (T315353)]]

Stashbot added a comment.Nov 8 2022, 9:35 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-08T21:35:34Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:854606|Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (T315353)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Nov 8 2022, 9:41 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-08T21:41:53Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:854606|Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (T315353)]] (duration: 06m 36s)

matmarex mentioned this in T322701: Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry '…' for key 'itid_itemid' / 'it_itemname'.Nov 8 2022, 11:11 PM
matmarex added a subtask: T322701: Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry '…' for key 'itid_itemid' / 'it_itemname'.

Reverted from group1 due to T315353.

gerritbot added a comment.Nov 14 2022, 1:36 PM

Change 856566 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (#2)

https://gerrit.wikimedia.org/r/856566

gerritbot added a comment.Nov 14 2022, 2:22 PM

Change 856566 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (#2)

https://gerrit.wikimedia.org/r/856566

Stashbot added a comment.Nov 14 2022, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-14T14:23:05Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:856566|Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (#2) (T315353)]]

Stashbot added a comment.Nov 14 2022, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-14T14:23:26Z] <taavi@deploy1002> taavi and matmarex: Backport for [[gerrit:856566|Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (#2) (T315353)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Nov 14 2022, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-14T14:30:11Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:856566|Enable wgDiscussionToolsEnablePermalinksBackend on group1 wikis (#2) (T315353)]] (duration: 07m 05s)

matmarex mentioned this in T323077: "Lock wait timeout exceeded" / "Deadlock found when trying to get lock" in "INSERT INTO `discussiontools_items` / `discussiontools_item_ids`".Nov 14 2022, 9:56 PM
matmarex mentioned this in T323079: "Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`".Nov 14 2022, 10:09 PM
matmarex mentioned this in T323080: "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`".
matmarex added subtasks: T323077: "Lock wait timeout exceeded" / "Deadlock found when trying to get lock" in "INSERT INTO `discussiontools_items` / `discussiontools_item_ids`", T323079: "Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`", T323080: "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`".Nov 14 2022, 10:12 PM
• ppelberg closed subtask T322701: Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry '…' for key 'itid_itemid' / 'it_itemname' as Resolved.Nov 19 2022, 1:18 AM
Ladsgroup added a comment.Nov 25 2022, 3:36 PM

I think I might have found the underlying problem here.
As I suspected, I think the DT updates (and probably any other secondary data update) are running twice in the same context.

For example, these two look similar if not almost identical:

But look at the start of stack trace. One is explicit call to $page->doSecondaryDataUpdates( $options ); in the job and one is deferred update being ran implicitly after the job is done which JobExecuter runs regardless of whether secondary data updates are done or not (see JobExecutor.php(105)). The only other possible explanation is that we have another job that completely unrelatedly queues secondary data updates in its context.

Ladsgroup added a comment.Nov 25 2022, 9:55 PM

That was a red herring but looking at the data, refreshlinks jobs are mostly useless and won't make any change to the output (assuming dt storage is filled) but ThreadItemStore::insertThreadItems is being called regardless, maybe we can do a short-circuit when revision id already exists in dt.

matmarex mentioned this in T330574: Links to comments on old page revisions go to the current version.Feb 26 2023, 7:37 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 26 2023, 8:10 PM
gerritbot added a comment.Mar 21 2023, 7:02 PM

Change 901697 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group2 wikis

https://gerrit.wikimedia.org/r/901697

gerritbot added a project: Patch-For-Review.Mar 21 2023, 7:02 PM
gerritbot added a comment.Mar 21 2023, 8:02 PM

Change 901697 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on group2 wikis

https://gerrit.wikimedia.org/r/901697

Stashbot added a comment.Mar 21 2023, 8:02 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-21T20:02:55Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:900331|Enable DiscussionTools_visualenhancements_newsectionlink_enable on labs for testing]], [[gerrit:901697|Enable wgDiscussionToolsEnablePermalinksBackend on group2 wikis (T315353)]]

Stashbot added a comment.Mar 21 2023, 8:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-21T20:04:27Z] <taavi@deploy2002> esanders and taavi and matmarex: Backport for [[gerrit:900331|Enable DiscussionTools_visualenhancements_newsectionlink_enable on labs for testing]], [[gerrit:901697|Enable wgDiscussionToolsEnablePermalinksBackend on group2 wikis (T315353)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2023, 8:10 PM
Stashbot added a comment.Mar 21 2023, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-21T20:20:35Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:900331|Enable DiscussionTools_visualenhancements_newsectionlink_enable on labs for testing]], [[gerrit:901697|Enable wgDiscussionToolsEnablePermalinksBackend on group2 wikis (T315353)]] (duration: 17m 40s)

matmarex moved this task from Doing to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 21 2023, 9:45 PM
matmarex added a project: Skipped QA.

This is done now: all new comments being posted are being indexed in the permalink database. Old comments will be handled in T315510 by the maintenance script runs.

matmarex closed this task as Resolved.Apr 3 2023, 6:07 PM
matmarex mentioned this in T334023: Large increase in insertThreadItems rate leading to db performance issues (was: Greater than average number of DBTransactionStateError/DBQueryErrors).Apr 4 2023, 9:51 PM
matmarex reopened this task as Open.Apr 6 2023, 8:46 PM
matmarex mentioned this in T334258: DiscussionTools can overload the database if DiscussionToolsEnablePermalinksBackend is enabled without running the persistRevisionThreadItems maintenance script.

Reverted from group2, caused T334258

matmarex moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Apr 6 2023, 8:48 PM
matmarex removed a parent task: T315510: Start maintenance script to backfill talk page comment database.Apr 17 2023, 11:21 PM
matmarex added a subtask: T334258: DiscussionTools can overload the database if DiscussionToolsEnablePermalinksBackend is enabled without running the persistRevisionThreadItems maintenance script.Apr 17 2023, 11:24 PM
matmarex closed subtask T334258: DiscussionTools can overload the database if DiscussionToolsEnablePermalinksBackend is enabled without running the persistRevisionThreadItems maintenance script as Resolved.
matmarex moved this task from Blocked / Needs More Work to Doing on the Editing-team (Kanban Board) board.Apr 17 2023, 11:26 PM
In T334258#8780782, @matmarex wrote:

The new plan to re-enable the feature without repeating this incident is: run the maintenance script first, then enable the config option, then run the maintenance script again on just the changes that will have occurred between these two steps and thus wouldn't have been processed.

matmarex closed subtask T323079: "Duplicate entry '0-XXX' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`" as Resolved.Jul 31 2023, 12:09 PM
• ppelberg moved this task from Doing to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Aug 1 2023, 4:50 PM
• ppelberg subscribed.

This ticket being resolved depends on permalinks being enabled and permalinks being enabled depends on T315510 being resolved.

matmarex edited subtasks, added: T339882: Bad rows in discussiontools_item_pages, discussiontools_item_revisions with itp_items_id, itr_itemid_id, itr_items_id equal to 0, T341811: DBQueryError: "Duplicate entry … for key 'itp_items_id_page_id'" in "INSERT INTO `discussiontools_item_pages`"; removed: T323077: "Lock wait timeout exceeded" / "Deadlock found when trying to get lock" in "INSERT INTO `discussiontools_items` / `discussiontools_item_ids`".Aug 2 2023, 12:26 PM
matmarex closed subtask T323080: "Duplicate entry 'XXX-YYY' for key 'itr_itemid_id_revision_id'" in "INSERT INTO `discussiontools_item_revisions`" as Resolved.Aug 8 2023, 2:31 PM
matmarex closed subtask T341811: DBQueryError: "Duplicate entry … for key 'itp_items_id_page_id'" in "INSERT INTO `discussiontools_item_pages`" as Resolved.
matmarex closed subtask T339882: Bad rows in discussiontools_item_pages, discussiontools_item_revisions with itp_items_id, itr_itemid_id, itr_items_id equal to 0 as Resolved.
gerritbot added a comment.Aug 8 2023, 7:22 PM

Change 946998 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on s2/s3/s5/s6 group2

https://gerrit.wikimedia.org/r/946998

gerritbot added a project: Patch-For-Review.Aug 8 2023, 7:22 PM
gerritbot added a comment.Aug 8 2023, 8:12 PM

Change 946998 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on s2/s3/s5/s6 group2

https://gerrit.wikimedia.org/r/946998

• ppelberg moved this task from Blocked / Needs More Work to Doing on the Editing-team (Kanban Board) board.Aug 8 2023, 8:13 PM
Stashbot added a comment.Aug 8 2023, 8:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-08T20:13:26Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:946998|Enable wgDiscussionToolsEnablePermalinksBackend on s2/s3/s5/s6 group2 (T315353)]]

Stashbot added a comment.Aug 8 2023, 8:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-08T20:14:57Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:946998|Enable wgDiscussionToolsEnablePermalinksBackend on s2/s3/s5/s6 group2 (T315353)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Aug 8 2023, 8:24 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-08T20:24:22Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:946998|Enable wgDiscussionToolsEnablePermalinksBackend on s2/s3/s5/s6 group2 (T315353)]] (duration: 10m 55s)

Stashbot added a comment.Aug 8 2023, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-08T20:29:13Z] <urbanecm> mwmaint1002: foreachwikiindblist 'group2 & s2' extensions/DiscussionTools/maintenance/persistRevisionThreadItems.php --current --all --touched-after=20230615000000 (T315353)

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2023, 8:30 PM
Stashbot added a comment.Aug 8 2023, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-08T20:30:26Z] <urbanecm> mwmaint1002: foreachwikiindblist 'group2 & s3' extensions/DiscussionTools/maintenance/persistRevisionThreadItems.php --current --all --touched-after=20230615000000 (T315353)

Stashbot added a comment.Aug 8 2023, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-08T20:30:37Z] <urbanecm> mwmaint1002: foreachwikiindblist 'group2 & s5' extensions/DiscussionTools/maintenance/persistRevisionThreadItems.php --current --all --touched-after=20230615000000 (T315353)

• ppelberg moved this task from Doing to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Sep 25 2023, 5:17 PM

Per T315353#9059976, this ticket remains blocked on T315510 being resolved.

Aklapper added a subtask: T315510: Start maintenance script to backfill talk page comment database.Sep 25 2023, 7:27 PM
gerritbot added a comment.Oct 12 2023, 7:35 PM

Change 965562 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on s7 group2

https://gerrit.wikimedia.org/r/965562

gerritbot added a project: Patch-For-Review.Oct 12 2023, 7:35 PM
gerritbot added a comment.Oct 12 2023, 8:58 PM

Change 965562 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable wgDiscussionToolsEnablePermalinksBackend on s7 group2

https://gerrit.wikimedia.org/r/965562

Stashbot added a comment.Oct 12 2023, 8:58 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-12T20:58:22Z] <thcipriani@deploy2002> Started scap: Backport for [[gerrit:965562|Enable wgDiscussionToolsEnablePermalinksBackend on s7 group2 (T315353)]]

Stashbot added a comment.Oct 12 2023, 8:59 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-12T20:59:36Z] <thcipriani@deploy2002> thcipriani and matmarex: Backport for [[gerrit:965562|Enable wgDiscussionToolsEnablePermalinksBackend on s7 group2 (T315353)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 12 2023, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-12T21:06:17Z] <thcipriani@deploy2002> Finished scap: Backport for [[gerrit:965562|Enable wgDiscussionToolsEnablePermalinksBackend on s7 group2 (T315353)]] (duration: 07m 55s)

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2023, 9:10 PM
Lucas_Werkmeister_WMDE changed the status of subtask T315510: Start maintenance script to backfill talk page comment database from Open to Stalled.Tue, Apr 2, 8:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL