Page MenuHomePhabricator

Upgrade Gerrit to 3.4.5
Closed, ResolvedPublic

Description

We currently run Gerrit 3.4.4, this task is to upgrade to 3.4.5

That is primarily to fix T307072: Gerrit 3.4 shows empty avatar next to usernames

Release notes: https://www.gerritcodereview.com/3.4.html#345

Event Timeline

Change 824122 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.4] Merge tag 'v3.4.5' into wmf/stable-3.4

https://gerrit.wikimedia.org/r/824122

Change 824122 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.4] Merge tag 'v3.4.5' into wmf/stable-3.4

https://gerrit.wikimedia.org/r/824122

Change 824134 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.4] Gerrit v3.4.5 and rebuild plugins

https://gerrit.wikimedia.org/r/824134

Change 824134 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.4] Gerrit v3.4.5 and rebuild plugins

https://gerrit.wikimedia.org/r/824134

Mentioned in SAL (#wikimedia-operations) [2022-08-17T09:03:50Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@e11e6a7]: Gerrit to 3.4.5 on gerrit 2002 # T315408

Mentioned in SAL (#wikimedia-operations) [2022-08-17T09:04:01Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@e11e6a7]: Gerrit to 3.4.5 on gerrit 2002 # T315408 (duration: 00m 11s)

Mentioned in SAL (#wikimedia-operations) [2022-08-17T09:09:06Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@e11e6a7]: Gerrit to 3.4.5 on gerrit1001 # T315408

Mentioned in SAL (#wikimedia-operations) [2022-08-17T09:09:15Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@e11e6a7]: Gerrit to 3.4.5 on gerrit1001 # T315408 (duration: 00m 09s)

Mentioned in SAL (#wikimedia-operations) [2022-08-17T09:10:53Z] <hashar> Upgraded Gerrit from 3.4.4 to 3.4.5 # T315408

hashar claimed this task.

I have updated both Gerrit including the plugins:

Name                           Version    Api-Version      Status   File
-------------------------------------------------------------------------------
codemirror-editor              v3.4.5     3.4.5            ENABLED  codemirror-editor.jar
commit-message-length-validator v3.4.5     3.4.5            ENABLED  commit-message-length-validator.jar
delete-project                 v3.4.5     3.4.5            ENABLED  delete-project.jar
download-commands              v3.4.5     3.4.5            ENABLED  download-commands.jar
gitiles                        v3.4.5     3.4.5            ENABLED  gitiles.jar
go-import                      6f14649    3.4.5            ENABLED  go-import.jar
healthcheck                    v3.3.0-35-g4294ad0 3.4.5            ENABLED  healthcheck.jar
hooks                          v3.4.5     3.4.5            ENABLED  hooks.jar
its-phabricator                d6a9913    3.4.5            ENABLED  its-phabricator.jar
javamelody                     v2.14-411-g8316d86 3.4.5            ENABLED  javamelody.jar
lfs                            1f4c412    3.4.5            ENABLED  lfs.jar
metrics-reporter-jmx           ffe1a46    3.4.5            ENABLED  metrics-reporter-jmx.jar
metrics-reporter-prometheus    f2ee1de    3.4.5            ENABLED  metrics-reporter-prometheus.jar
motd                           3d174f8    3.4.5            ENABLED  motd.jar
plugin-manager                 v3.4.5     3.4.5            ENABLED  plugin-manager.jar
replication                    v3.4.5     3.4.5            ENABLED  replication.jar
reviewers                      02b8c95    3.4.5            ENABLED  reviewers.jar
reviewnotes                    v3.4.5     3.4.5            ENABLED  reviewnotes.jar
singleusergroup                v3.4.5     3.4.5            ENABLED  singleusergroup.jar
webhooks                       v3.4.5     3.4.5            ENABLED  webhooks.jar
zuul                           16a217c    3.4.5            ENABLED  zuul.jar

Since this day the replication from gerrit1001 to gerrit2002 has stopped working. T315942

Did the sshd (mina) version change with this? That would explain it if it is indeed:

https://issues.apache.org/jira/browse/SSHD-1163

Gerrit 3.4 release notes say: "Deprecated JCraft JSch client library is replaced with MINA SSHD client library per default. There is still option to switch to using JCraft JSch client library. Support for JCraft JSch will be removed in the next gerrit release.
"

https://groups.google.com/g/repo-discuss/c/sIhjyblUh4A

"I added new configuration option to re-enabled
deprecated kex algorithms: sshd.enableDeprecatedKexAlgorithms = true"

^ we should try this

I tried a bunch of things at T315942 and restarted gerrit a couple times but it's not solved yet.

Change 825845 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.4] Revert "Gerrit v3.4.5 and rebuild plugins"

https://gerrit.wikimedia.org/r/825845

Change 825845 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.4] Revert "Gerrit v3.4.5 and rebuild plugins"

https://gerrit.wikimedia.org/r/825845

Change 827163 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.4] Gerrit v3.4.5 and rebuild plugins [2]

https://gerrit.wikimedia.org/r/827163

Change 827163 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.4] Gerrit v3.4.5 and rebuild plugins [2]

https://gerrit.wikimedia.org/r/827163

I have upgraded Gerrit to 3.4.5 again after the ssh replication to Gerrit replica got fixed (T315942).