Page MenuHomePhabricator

Depicts = 'some value' breaks cancel button and potentially some edits
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:
This prevents the list of initial depicts statements from being generated, but that leaves it in the same state it was for the previous image.

After cancelling, the statements will revert to those on the previous image.

What should have happened instead?:
When loading the new image, the initial state should be saved even if any error occurs.

Technical info:
There's an uncaught exception on line 102 in populate.js when the image first loads:
item: depictStatement.mainsnak.datavalue.value.id
This prevent it from finishing the usual sequence of steps to initialise the new image.

Event Timeline

NavinoEvans created this task.

Change 824509 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@master] Depicts = 'some value' breaks cancel button and potentially some edits

https://gerrit.wikimedia.org/r/824509

Change 824509 merged by jenkins-bot:

[labs/tools/Isa@master] Depicts = 'some value' breaks cancel button and potentially some edits

https://gerrit.wikimedia.org/r/824509

NavinoEvans moved this task from Review to Merged on the ISA board.

Change 937357 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Eugene233):

[labs/tools/Isa@m2c-rollback] Depicts = 'some value' breaks cancel button and potentially some edits

https://gerrit.wikimedia.org/r/937357

Change 937357 merged by jenkins-bot:

[labs/tools/Isa@m2c-rollback] Depicts = 'some value' breaks cancel button and potentially some edits

https://gerrit.wikimedia.org/r/937357