This is to remove suggestions that have been marked as rejected by the Google Vision api (i.e. nothing to do with rejected suggestions within ISA)
Line 28 of machine-vision.js we need to change:
.filter(function(suggestion) {return suggestion.state !== 'accepted';})To:
.filter(function(suggestion) {return suggestion.state === 'unreviewed';})| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't include Google Vision suggestions with status "rejected" | labs/tools/Isa | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T312872 Innovation Lab – Image to Concept (iteration 1) | ||
| Resolved | BUG REPORT | Eugene233 | T315414 Only include Google Vision suggestions with status "unreviewed" |
Change 824483 had a related patch set uploaded (by Eugene233; author: Eugene233):
[labs/tools/Isa@master] Don't include Google Vision suggestions with status "rejected"
My apologies @Eugene233, I just realised we need to expand this a little bit. We actually have "withheld" and "not-displayed" statuses that we should remove as well.
So we're actually only keeping the "unreviewed" status for now.
So lets make the filter function into
.filter(function(suggestion) {return suggestion.state === 'unreviewed';})Change 824483 merged by jenkins-bot:
[labs/tools/Isa@master] Don't include Google Vision suggestions with status "rejected"