[Regression] Pages which are supposed to have full-width no longer have full-width layout
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	abi_
	Aug 17 2022, 4:44 PM

Description

Steps to replicate the issue (include links if applicable):

With latest Vector go to the Special:RecentChanges
Collapse the sidebar

What happens?:
You'll notice that the content container (.mw-content-container) does not expand to fit the empty space. See image below:

What should have happened instead?:
The content container should have expanded to fill the empty space.


frwiki	beta cluster

Software version (skip for WMF-hosted wikis like Wikipedia):
Vector 2022 master

Other information (browser name/version, screenshots, etc.):

Looks like it was caused due to a patch related to T314579
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/823162

The related style also no longer applies:

.skin-vector-disable-max-width .vector-layout-grid .mw-content-container {
  max-width: none;
  width: 100%;
}

It appears to be working well on https://meta.wikimedia.org/w/index.php?title=Main_Page&action=history

QA

QA Results - Prod

AC	Status	Details
1	✅	T315460#8205004
2	✅	T315460#8205004

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/Vector	wmf/1.39.0-wmf.25	+6 -2	Layout: Restore disabling of max width on certain pages
	mediawiki/skins/Vector	master	+6 -2	Layout: Restore disabling of max width on certain pages

Customize query in gerrit

Related Objects

Mentioned In: T315723: [Regression] Vector 2022 does not scale to full width on edit pages when you hide sidebar
Mentioned Here: T315653: Regression: fixed width broken on Vector (2022)
T314579: [ToC] Content should be centered when TOC is collapsed

Event Timeline

abi_ created this task.Aug 17 2022, 4:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2022, 4:44 PM

Jdrewniak renamed this task from Content container no longer expands when sidebar is collapsed to [Rergession] Special pages no longer have 100% layout.Aug 17 2022, 6:46 PM

Jdrewniak added projects: Desktop Improvements (Vector 2022), Readers-Web-Backlog.

Jdrewniak added subscribers: ovasileva, • alexhollender_WMF.

Jdrewniak renamed this task from [Rergession] Special pages no longer have 100% layout to [Rergession] Special pages no longer have full-width layout.Aug 17 2022, 6:49 PM

Jdrewniak updated the task description. (Show Details)

Jdrewniak updated the task description. (Show Details)Aug 17 2022, 7:39 PM

TheresNoTime renamed this task from [Rergession] Special pages no longer have full-width layout to [Regression] Special pages no longer have full-width layout.Aug 17 2022, 7:41 PM

This looks like a specificity issue where the selector for the open/closed table of contents overrides the
.skin-vector-disable-max-width .mw-content-container rule.

Screen Shot 2022-08-17 at 3.58.14 PM.png (550×1 px, 121 KB)

Jdlrobson edited projects, added Readers-Web-Backlog (Kanbanana-2022-23-Q1), Regression; removed Readers-Web-Backlog.Aug 18 2022, 6:21 AM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2022-23-Q1) board.Aug 18 2022, 6:34 AM

ovasileva triaged this task as High priority.Aug 18 2022, 9:07 AM

This is one of these rare cases where !important makes sense IMO

I think this is related, but articles now at Basque Wikipedia and French Wikipedia are full width again.

In T315460#8168439, @Theklan wrote:

I think this is related, but articles now at Basque Wikipedia and French Wikipedia are full width again.

Now tracking in T315653: Regression: fixed width broken on Vector (2022)

Jdlrobson mentioned this in T315723: [Regression] Vector 2022 does not scale to full width on edit pages when you hide sidebar.Aug 22 2022, 5:43 AM

Jdlrobson closed this task as a duplicate of T315653: Regression: fixed width broken on Vector (2022).Aug 22 2022, 6:24 AM

My mistake. This one's still broken.

Jdlrobson renamed this task from [Regression] Special pages no longer have full-width layout to [Regression] Pages which are supposed to have full-width no longer have full-width layout.Aug 22 2022, 7:11 AM

Jdlrobson merged a task: T315723: [Regression] Vector 2022 does not scale to full width on edit pages when you hide sidebar.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added subscribers: Soda, Nux, Msz2001 and 3 others.

Jdlrobson updated the task description. (Show Details)Aug 22 2022, 7:14 AM

ovasileva raised the priority of this task from High to Unbreak Now!.Aug 22 2022, 7:24 AM

Change 825295 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Layout: Restore disabling of max width on certain pages

https://gerrit.wikimedia.org/r/825295

gerritbot added a project: Patch-For-Review.Aug 22 2022, 10:34 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/df95bfe300/w

Change 825295 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Layout: Restore disabling of max width on certain pages

https://gerrit.wikimedia.org/r/825295

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2022, 12:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 22 2022, 1:00 PM

Just to make sure, are there ever any cases where .skin-vector-disable-max-width is applied to a page and the page has a TOC?

In T315460#8174769, @bwang wrote:

Just to make sure, are there ever any cases where .skin-vector-disable-max-width is applied to a page and the page has a TOC?

There's TOC on [[Special:EditWatchlist]]. However it's style-less at the moment (side note: is it already tracked?)

In T315460#8174819, @Msz2001 wrote:

In T315460#8174769, @bwang wrote:

Just to make sure, are there ever any cases where .skin-vector-disable-max-width is applied to a page and the page has a TOC?

There's TOC on [[Special:EditWatchlist]]. However it's style-less at the moment (side note: is it already tracked?)

@Msz2001 - do you have a link for this page? I can't seem to reproduce on [[Special:EditWatchlist]] on enwiki or plwiki

In T315460#8174769, @bwang wrote:

Just to make sure, are there ever any cases where .skin-vector-disable-max-width is applied to a page and the page has a TOC?

In general, I don't think so, or it would be inline as in the example above, but not 100% sure

In T315460#8174834, @ovasileva wrote:

In T315460#8174819, @Msz2001 wrote:

In T315460#8174769, @bwang wrote:

Just to make sure, are there ever any cases where .skin-vector-disable-max-width is applied to a page and the page has a TOC?

There's TOC on [[Special:EditWatchlist]]. However it's style-less at the moment (side note: is it already tracked?)

@Msz2001 - do you have a link for this page? I can't seem to reproduce on [[Special:EditWatchlist]] on enwiki or plwiki

The URL I have in my address bar is: https://pl.wikipedia.org/wiki/Specjalna:Edytuj_obserwowane?uselang=en&useskin=vector-2022

I'm getting this TOC on my main account, where there are 6 namespaces (i.e. headings) but not on my sockpuppet (where there are only pages from a single namespace).

In T315460#8174849, @Msz2001 wrote:

In T315460#8174834, @ovasileva wrote:

In T315460#8174819, @Msz2001 wrote:

In T315460#8174769, @bwang wrote:

Just to make sure, are there ever any cases where .skin-vector-disable-max-width is applied to a page and the page has a TOC?

There's TOC on [[Special:EditWatchlist]]. However it's style-less at the moment (side note: is it already tracked?)

@Msz2001 - do you have a link for this page? I can't seem to reproduce on [[Special:EditWatchlist]] on enwiki or plwiki

The URL I have in my address bar is: https://pl.wikipedia.org/wiki/Specjalna:Edytuj_obserwowane?uselang=en&useskin=vector-2022

I'm getting this TOC on my main account, where there are 6 namespaces (i.e. headings) but not on my sockpuppet (where there are only pages from a single namespace).

@ovasileva After a bit of testing, the TOC gets displayed only if the watchlist contains 31 or more items on it. The number of namespaces doesn't matter (EDIT: sorry, at least two namespaces are required).

@ovasileva After a bit of testing, the TOC gets displayed only if the watchlist contains 31 or more items on it. The number of namespaces doesn't matter (EDIT: sorry, at least two namespaces are required).

BTW this looks like another bug. The watchlist is appearing unstyled and not showing in the sidebar like it should be (we should open a new ticket for that!). This page however doesn't have a max-width so shouldn't be impacted.

Jdlrobson lowered the priority of this task from Unbreak Now! to High.Aug 22 2022, 5:24 PM

Jdlrobson moved this task from Upcoming to QA in Prod on the Readers-Web-Backlog (Kanbanana-2022-23-Q1) board.

Olga says this should be backported

Change 825280 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.25] Layout: Restore disabling of max width on certain pages

https://gerrit.wikimedia.org/r/825280

gerritbot added a project: Patch-For-Review.Aug 22 2022, 5:38 PM

ovasileva assigned this task to bwang.Aug 22 2022, 5:39 PM

Change 825280 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.25] Layout: Restore disabling of max width on certain pages

https://gerrit.wikimedia.org/r/825280

Mentioned in SAL (#wikimedia-operations) [2022-08-22T20:51:36Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.25/skins/Vector/: e0ff7634ac529acec6d298992b45b23203b682c1: Layout: Restore disabling of max width on certain pages (T315460) (duration: 03m 37s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 22 2022, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2022, 9:31 PM

bwang reassigned this task from bwang to Edtadros.Aug 22 2022, 9:34 PM

bwang moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-2022-23-Q1) board.

ovasileva moved this task from QA to QA in Prod on the Readers-Web-Backlog (Kanbanana-2022-23-Q1) board.Aug 23 2022, 5:08 PM

(skipping estimate since it was a regression relating to estimated work)

Test Result - Prod

Status: ✅ PASS
Environment: metawiki, wikisource
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Check https://meta.wikimedia.org/w/index.php?title=Main_Page&useskin=vector-2022&action=history is full width

Screen Shot 2022-08-31 at 7.17.36 PM.png (544×1 px, 148 KB)

✅ AC2: Check https://en.wikisource.org/w/index.php?title=Page:Oriental_Scenery_%E2%80%94_One_Hundred_and_Fifty_Views_of_the_Architecture,_Antiquities,_and_Landscape_Scenery_of_Hindoostan.djvu/8&useskin=vector-2022&action=edit is full width

Screen Shot 2022-08-31 at 7.18.14 PM.png (776×1 px, 188 KB)

Edtadros updated the task description. (Show Details)Sep 1 2022, 2:21 AM

ovasileva closed this task as Resolved.Sep 1 2022, 8:38 AM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/df95bfe300/w/~~

	F35503254: Screen Shot 2022-08-31 at 7.18.14 PM.png
	Sep 1 2022, 2:20 AM

	F35503252: Screen Shot 2022-08-31 at 7.17.36 PM.png
	Sep 1 2022, 2:20 AM

	F35470435: Screen Shot 2022-08-17 at 3.58.14 PM.png
	Aug 17 2022, 8:00 PM

	F35469882: Screen Shot 2022-08-17 at 2.47.49 PM.png
	Aug 17 2022, 6:49 PM

	F35469880: Screen Shot 2022-08-17 at 2.47.38 PM.png
	Aug 17 2022, 6:49 PM

	F35484129: image.png
	Aug 22 2022, 3:48 PM

	F35477708: irudia.png
	Aug 19 2022, 10:04 AM

[Regression] Pages which are supposed to have full-width no longer have full-width layoutClosed, ResolvedPublic0 Estimated Story PointsBUG REPORTActions