Page MenuHomePhabricator

Deprecate unused IPInfo table, ipinfo_ip_changes
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

The ipinfo_ip_changes table added in T297696. It was created preemptively for a feature (counting global contributions) that 1. may no longer be implemented and 2. if implemented, will most likely not be implemented as part of IPInfo, because it would probably be useful for features outside of IPInfo, e.g. CheckUser.

Given that, we should delete this unused table.

Notes

Acceptance criteria

  • If the table ipinfo_ip_changes exists, then running maintenance/update.php deletes it
  • If the table does not already exist, there are no changes to IPInfo (and no errors) when running maintenance/update.php

Event Timeline

STran set the point value for this task to 2.Aug 22 2022, 6:49 PM

Change 826628 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Deprecate unused IPInfo table, ipinfo_ip_changes

https://gerrit.wikimedia.org/r/826628

Change 826628 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Deprecate unused IPInfo table, ipinfo_ip_changes

https://gerrit.wikimedia.org/r/826628

dom_walden subscribed.

The ipinfo_ip_changes table is no longer on beta nor my local environment. This covers both MySQL and SQLite.

I notice the beta jenkins job just after the merge of this (https://integration.wikimedia.org/ci/view/Beta/job/beta-update-databases-eqiad/61171/console) we have:

Dropping table ipinfo_ip_changes ...done.