Page MenuHomePhabricator

Add configurable Thumbnail demo
Open, LowestPublic

Description

Background

We should strive to provide configurable demos of all our components (even the ones used 'internally'), so users can quickly understand the purpose of their props and evaluate suitability.
Including configurable sections will also allow us, in some cases, to reduce the number of instances that we need to showcase in the demo pages, since said instances can be obtained/showcased via configuration.

Goals

Following the principle stated above, we should include a configurable version of the Thumbnail component that allows users to see which of its properties can be adjusted. Technical feasibility should be confirmed but, ideally, users should be able to:

  • Switch between image and placeholder thumbnails
  • Edit the custom placeholder icon (applied to placeholder thumbnail only)
Acceptance criteria
  • The Thumbnail demo page includes a 'Configurable' section that allows users to adjust and test the properties of this component.

Event Timeline

DannyS712 subscribed.

I already created the infrastructure for this in my patch for T314236: docs: Add configurable Card demo which adds support for a "thumbnail" property type, once that patch is merged I'll add a configurable Thumbnail demo

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.