Page MenuHomePhabricator

[Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs
Closed, ResolvedPublic4 Estimated Story PointsFeature

Description

Feature summary (what you would like to be able to do and where):

Special:CentralNotice currently replaces the namespaces tabs on its special pages with 2 links via hook. In the future this will not be supported.
This is the hook in question:
https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/2f02da42d990f4e5596c643721aaf18450482d38/extension.json#315

The links in question look like this:

Screen Shot 2022-08-18 at 3.11.32 PM.png (164×1 px, 24 KB)

In T313349 we made it possible for special pages to register menus. This will soon be added to Minerva and Vector 2022 skins.
Please see example link here:
https://gerrit.wikimedia.org/r/c/816211

TODO

Event Timeline

Dwisehaupt set the point value for this task to 4.Sep 9 2022, 4:34 PM

Could this be prioritized fundraising team? I'm happy to help if it's not clear what this task is about.

Change 934428 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@master] On admin interface, use nav links if supported

https://gerrit.wikimedia.org/r/934428

Instructions for testing on FR-Tech Docker:

No change under classic Vector skin (which is currently still default on Meta):
https://localhost:9010/wiki/Special:CentralNotice

Navigation links under Vector 2022:
https://localhost:9010/wiki/Special:CentralNotice?useskin=vector-2022

Navigation links under Mobile skin (requires updating Docker setup):
https://localhost:9010/wiki/Special:CentralNotice?useskin=minerva

For the last two links, be sure to re-add the URL parameter after clicking on the navigation link.

(@Jdlrobson I'm not sure why I'm getting strange formatting when I use useformat=mobile as the URL parameter, but I assume it's something to do with my local setup, rather than the attached patch.)

Thanks much!!!

Change 934428 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] On admin interface, use nav links if supported

https://gerrit.wikimedia.org/r/934428

@Jdlrobson checking in on this task - was it resolved with the last patch?

LGTM. Thanks for working on this @AndyRussG_volunteer !