Page MenuHomePhabricator

[Visual refinements] Fix language button styling
Open, LowPublic

Description

Description

The language button in the page header is not consistent with the style guide.

statecurrentcorrectnotes
hover
Screen Shot 2022-08-18 at 3.32.40 PM.png (128×390 px, 26 KB)
Screen Shot 2022-08-18 at 3.51.49 PM.png (118×296 px, 22 KB)
text color should be color-progressive--hover #447ff5, background color should be background-color-progressive--subtle #eaf3ff
focus
Screen Shot 2022-08-18 at 3.52.40 PM.png (122×368 px, 25 KB)
(waiting on DST)text color is using color-progressive--focus, background color is using background-color-transparent and focus border color is border-color-progressive--focus
active
Screen Shot 2022-08-18 at 3.35.08 PM.png (122×360 px, 24 KB)
(waiting on DST)text color is using color-inverted, background color is using background-color-progressive--active

Event Timeline

alexhollender_WMF renamed this task from Fix language button styling to [Visual refinements] Fix language button styling.Aug 19 2022, 2:12 PM
Jdlrobson added a subscriber: NBaca-WMF.

The language button uses the mw-ui-button styles in MediaWiki core (https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.ui.button/button.less). These are meant to be synced with Codex and are used throughout the MediaWiki interface. @NHillard-WMF I'm wondering if it makes sense for the design systems team to maintain those stylesheets going forward rather than the web team as they are meant to be stopgap solutions until we can use Codex on the server side ?

What I'd see as most useful approach is to extend the mediawiki.skin.variables with settled Codex tokens, that are filled into WikimediaUI Base as carrying library (or provide the tokens itself in MediaWiki core) and replace all mediawiki.ui vars with the new Codex token (variable) definitions. Please also see related task T314086: Design System Foundation: Define & Implement Critical "Global" Visual Styles.

LGoto triaged this task as Medium priority.Aug 29 2022, 5:47 PM
ovasileva lowered the priority of this task from Medium to Low.Aug 29 2022, 5:48 PM