Page MenuHomePhabricator

Use smooth scroll when clicking on "Latest comment" links
Open, Needs TriagePublic

Description

In DiscussionTools we use a smooth scroll (via jQuery via OOUI) whenever we are scrolling something to view (excluding the initial page load). Instant jump scrolling can lead to users feeling lost on the page, especially on smaller screens.

On mobile there is code inside Toggler that ensures the section containing the content you are scrolling to is opened. The code also does a jump scroll, so that will need to be suppressed when DiscussionTools is doing the scrolling.

Event Timeline

Change 822099 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Toggler: Support other code handling scrolling into view

https://gerrit.wikimedia.org/r/822099

Esanders renamed this task from Use smooth scroll when clicking on "Lates comment" links to Use smooth scroll when clicking on "Latest comment" links.Aug 19 2022, 10:50 AM
matmarex subscribed.

Needs a different implementation per our discussion

Change 820233 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Latest comment link: Use highlighter.setHash

https://gerrit.wikimedia.org/r/820233

Change #822099 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Toggler: Support other code handling scrolling into view

Reason:

Hello this is an automated message.
I am abandoning this patch as it over a year old, and is not currently in a mergeable state. This has nothing to do with the quality of the patch.

If you still care about this patch, please feel free to restore it and rebase it, and we can happily continue the conversation to help you get it merged.

https://gerrit.wikimedia.org/r/822099