Page MenuHomePhabricator
Create Task
Maniphest T315696

ZTypedList: check validity of new elements before adding them
Closed, ResolvedPublic
Actions

Description

Validity should be checked in appendZTypedList, appendArray, and probably also in __construct.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ZTypedList: check types of new elements in constructormediawiki/extensions/WikiLambdamaster+18 -5
ZTypedList: check types of new elements in append methodsmediawiki/extensions/WikiLambdamaster+148 -4
Customize query in gerrit

Event Timeline

DMartin-WMF created this task.Aug 19 2022, 7:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2022, 7:54 PM
DMartin-WMF claimed this task.Aug 19 2022, 7:55 PM
DMartin-WMF moved this task from Incoming to Ready: G3. Meta-data about calls on the Abstract Wikipedia team (Phase θ – Throttling) board.
DMartin-WMF added a project: Abstract Wikipedia Fix-It tasks.Sep 21 2022, 1:11 AM
gerritbot added a comment.Sep 28 2022, 4:01 AM

Change 835731 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] ZTypedList: check types of new elements in append methods

https://gerrit.wikimedia.org/r/835731

gerritbot added a project: Patch-For-Review.Sep 28 2022, 4:01 AM
gerritbot added a comment.Sep 30 2022, 4:48 AM

Change 835731 merged by David Martin:

[mediawiki/extensions/WikiLambda@master] ZTypedList: check types of new elements in append methods

https://gerrit.wikimedia.org/r/835731

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Sep 30 2022, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 30 2022, 5:30 AM
gerritbot added a comment.Sep 30 2022, 1:52 PM

Change 837119 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] ZTypedList: check types of new elements in append methods

https://gerrit.wikimedia.org/r/837119

gerritbot added a project: Patch-For-Review.Sep 30 2022, 1:52 PM
DMartin-WMF closed this task as Resolved.Oct 3 2022, 7:10 PM
gerritbot added a comment.Oct 21 2022, 6:39 PM

Change 837119 abandoned by David Martin:

[mediawiki/extensions/WikiLambda@master] ZTypedList: check types of new elements in constructor

Reason:

Per discussion in the ticket, we needn't do type checking in ZObject PHP constructors. The corrected calls to ZTypedList::buildType have been merged separately: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/844079

https://gerrit.wikimedia.org/r/837119

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2022, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits