Maniphest T315725

Setup user interface for "rejecting" suggestions
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	NavinoEvans
	Aug 20 2022, 2:23 PM

Tags

Referenced Files

	F35481000: image.png
	Aug 20 2022, 2:23 PM

Subscribers

Sebastian_Berlin-WMSE

Description

Feature summary:
Create the user interface for rejecting a statement. The suggestion should be removed from the list, but no actual saving to the database is needed in this patch (See T316167: Save rejected statements to ISA database).

We should create an "accept" and "reject" button within each suggestion tag, using the icons below or similar:

image.png (54×176 px, 2 KB)

IMPORTANT: Currently you accept a suggestion by clicking anywhere on the tag. This click handler needs to be removed as we only want to accept a suggestion when the user click on the new check icon.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow user to "reject" suggestions	labs/tools/Isa	master	+29 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Feature	Sebastian_Berlin-WMSE	T312872 Innovation Lab – Image to Concept (iteration 1)
		Resolved	Feature	Eugene233	T315727 Don't suggest statements current user has rejected
		Resolved	Feature	Eugene233	T316346 Create API route to get rejected statements for logged in user
		Resolved	Feature	Eugene233	T315733 Only reject a suggestion after multiple user choices
		Resolved	Feature	Eugene233	T315669 Add "user" to saved suggestion data
		Resolved	Feature	Eugene233	T316167 Save rejected statements to ISA database
		Resolved	Feature	Eugene233	T315725 Setup user interface for "rejecting" suggestions

Event Timeline

NavinoEvans created this task.Aug 20 2022, 2:23 PM

NavinoEvans moved this task from Incoming features to Pending on the ISA board.

NavinoEvans added a parent task: T312872: Innovation Lab – Image to Concept (iteration 1).

NavinoEvans added a subtask: T315727: Don't suggest statements current user has rejected.Aug 20 2022, 6:11 PM

NavinoEvans removed a subtask: T315727: Don't suggest statements current user has rejected.

NavinoEvans added a parent task: T315727: Don't suggest statements current user has rejected.

NavinoEvans removed a parent task: T312872: Innovation Lab – Image to Concept (iteration 1).Aug 20 2022, 6:14 PM

NavinoEvans added a parent task: T315733: Only reject a suggestion after multiple user choices.Aug 20 2022, 10:22 PM

NavinoEvans removed a parent task: T315733: Only reject a suggestion after multiple user choices.Aug 20 2022, 10:25 PM

NavinoEvans triaged this task as High priority.Aug 20 2022, 10:35 PM

Change 826359 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@master] Allow user to "reject" suggestions

https://gerrit.wikimedia.org/r/826359

gerritbot added a project: Patch-For-Review.Aug 24 2022, 6:11 PM

Eugene233 claimed this task.Aug 24 2022, 6:13 PM

NavinoEvans moved this task from Pending to Review on the ISA board.Aug 24 2022, 9:49 PM

NavinoEvans renamed this task from Allow user to "reject" suggestions to Setup user interface for "rejecting" suggestions.Aug 24 2022, 10:23 PM

NavinoEvans updated the task description. (Show Details)

NavinoEvans added a parent task: T316167: Save rejected statements to ISA database.

NavinoEvans removed a parent task: T315727: Don't suggest statements current user has rejected.Aug 24 2022, 10:26 PM

Change 826359 merged by jenkins-bot:

[labs/tools/Isa@master] Allow user to "reject" suggestions

https://gerrit.wikimedia.org/r/826359

Eugene233 mentioned this in rLTIS9f7936e72123: Allow user to "reject" suggestions.Aug 25 2022, 3:27 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2022, 3:30 PM

NavinoEvans moved this task from Review to Merged on the ISA board.Aug 25 2022, 4:12 PM

NavinoEvans closed this task as Resolved.Aug 29 2022, 1:18 PM