Page MenuHomePhabricator

CharInsert has no PHPUnit tests
Closed, DeclinedPublic

Event Timeline

It does have tests – parser tests (rECHI tests/parser/parserTests.txt). Since all this extension does is providing an extension tag, I don’t think adding unit tests could catch any additional regressions.

It does have tests – parser tests (rECHI tests/parser/parserTests.txt). Since all this extension does is providing an extension tag, I don’t think adding unit tests could catch any additional regressions.

It's more a variant of T315768: Can we make parser tests show as PHP test coverage?...

But this variant nature should be visible in this task. I see three options:

  • Close this task as invalid. What the title says (no tests at all) is simply not true.
  • Add T315768 as a subtask. What you probably meant (no test that would be recognized https://doc.wikimedia.org/cover-extensions/) should resolved by that page recognizing the existing tests, not by adding some useless unit tests just to make the counter green.
  • Close this task as a duplicate of T315768. Resolving T315768 is not a prerequisite to resolve this task, it automatically resolves this.
thiemowmde renamed this task from CharInsert has no tests to CharInsert has no PHPUnit tests.Jun 15 2023, 9:38 AM

I see no reason to add PHPUnit tests to an extension properly covered by parser tests.