Page MenuHomePhabricator
Create Task
Maniphest T315771

Citoid has no PHPUnit tests
Open, LowestPublic
Actions

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT186850 Wikimedia-deployed extensions/skins with no PHPUnit coverage
 OpenNoneT315771 Citoid has no PHPUnit tests

Event Timeline

Reedy created this task.Aug 21 2022, 12:28 PM
Mvolz renamed this task from Citoid has no tests to Citoid has no php tests.Aug 21 2022, 1:08 PM
Mvolz moved this task from Backlog to Extension on the Citoid board.Aug 31 2022, 1:26 PM
Mvolz added projects: VisualEditor, VisualEditor-MediaWiki-References.
HouseBlaster moved this task from Unsorted to Test coverage on the Technical-Debt board.Nov 23 2022, 1:00 AM
thiemowmde triaged this task as Lowest priority.Feb 21 2023, 11:28 AM
thiemowmde subscribed.

I just had a quick look. There are about 10 lines of non-boilerplate PHP code in this extension. All it effectively does is conditionally loading JavaScript modules and configuration. To be honest I think there is nothing that would benefit from having PHPUnit test coverage.

thiemowmde renamed this task from Citoid has no php tests to Citoid has no PHPUnit tests.Jun 15 2023, 9:39 AM
Mvolz subscribed.Jun 15 2023, 10:43 AM
In T315771#8632084, @thiemowmde wrote:

I just had a quick look. There are about 10 lines of non-boilerplate PHP code in this extension. All it effectively does is conditionally loading JavaScript modules and configuration. To be honest I think there is nothing that would benefit from having PHPUnit test coverage.

Should this just be declined then?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits