| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ext.navigationTiming: Use native packageFiles for virtual config.json | mediawiki/extensions/NavigationTiming | master | +8 -63 |
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T186850 Wikimedia-deployed extensions/skins with no PHPUnit coverage | |||
| Resolved | • Krinkle | T315796 NavigationTiming has no PHPUnit tests |
Event Timeline
Comment Actions
It also has no meaningful PHP code. It only registers a module and a hook to load said module. I'll re-use this task to remove some of the unneeded PHP code.
Comment Actions
Yeah... Tasks filed more for visiblity than anything else.
Certainly could write tests for the hooks, but I'm not sure there's much value in doing that.
Comment Actions
Change 840682 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/extensions/NavigationTiming@master] ext.navigationTiming: Use native packageFiles for virtual config.json file
Comment Actions
Change 840682 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] ext.navigationTiming: Use native packageFiles for virtual config.json
Comment Actions
The only PHP code left now is one line of code:
$out->addModules( 'ext.navigationTiming' );