danny.leinad wrote:

Hi,

Is there any progess to fix this bug?

danny.leinad wrote:

PS Also in Polish version {{GRAMMAR}} brokes UploadWizard.

Escalating priority.

On Wikimedia Commons, please substitute the message in the MediaWiki: namespace for now to not use the grammar keyword, or point me to the relevant messages so I can do so (User:Eloquence on Commons). We'll look into adding grammar support ASAP.

See
http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UploadWizard/UploadWizard.i18n.php?revision=96108&view=markup for a full list of relevant MW messages.

I have changed all occurences of {{SITENAME}} to "this site" for the messages of the UploadWizard in r96131. I also removed any usage of GRAMMAR in the same file, and removed those messages in translatewiki.net. Roan is backporting r96131 to 1.17wmf. After that he will deploy it and run LocalisationUpdate, so the issue is gone for now.

Erik has requested Neil, the head developer of the UploadWizard and me to get GRAMMAR support in the JavaScript parts of MediaWiki. That may not be that simple, but we'll keep you updated here!

The failure here looks similar if not identical to Bug 30707. {{GRAMMAR}} support is a separate issue, though.

shealen.clare wrote:

This bug has not been touched in at least six months. With this in mind, I've been asked by the bugmeister to bump this bug's priority down for "High". Concerns can be addressed to mah@everybody.org.

Thehelpfulonewiki wrote:

Reassigning to wikibugs-l per bug 37789

I'm going to go ahead and take a stab, and say that this is related to the fact that JavaScript messages aren't handled very well. If that's the case, maybe we should be filing bugs against MediaWiki/JavaScript.

Hi Mark. From the bug triage I can remember that it's basically using the wrong i18n calls in UploadWizard. It's using a lot of gM() where it should be using mw.msg().

Core doesn't use this method, and only a few remaining extensions use it (EducationProgram, Contest, PageTriage, UploadWizard).

OK! Things I learned today!

I'll try to whip up a patch for this after lunch, should be quickish.

p.selitskas wrote:

As long as mw.language.convertGrammar works just fine, this ticket may be considered as RESOLVED.

gM now maps to mw.jqueryMsg.getMessageFunction since 82d61f796a4d24adaf8419ecdbb333496be2c3f0

So is that the right function ? Do we possible want to do actual replacing of gM() everywhere ?

Do we need to revert r96131 that removed {{SITENAME}} and {{GRAMMER}} from the UW messages ? On first sight it seems that the message reverted there are now all in place again, but not 100% sure.

(In reply to comment #13)

Do we possible want to do actual replacing of
gM() everywhere ?

Yes.

Do we need to revert r96131 that removed {{SITENAME}} and {{GRAMMER}} from the
UW messages ? On first sight it seems that the message reverted there are now
all in place again, but not 100% sure.

Yes.

Is someone working on this anymore? anyway the summary isn't valid anymore, only some text replacement has to be made

Fixed summary.

Any updates?

In T31582#1119841, @Ricordisamoa wrote:

Any updates?

Did you test the bug?

This message appears correctly in UploadWizard these days:

And it's still using {{GRAMMAR:}} and {{SITENAME}}: "mwe-upwiz-license-external-invalid": "Гэты файл распаўсюджваецца на $1 на ўмовах ліцэнзіі $2. На жаль, гэтая ліцэнзія не падыходзіць для выкарыстаньня ў {{GRAMMAR:месны|{{SITENAME}}}}."

This was probably fixed with T22962.