Page MenuHomePhabricator

Topic containers display subscribe link for unsubscribeable talk page sections
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. In your preferences, enable (manual) topic subscriptions and disable topic containers.
  2. Open https://hu.wikipedia.org/w/index.php?title=Szerkesztővita:Tgr&oldid=25181718#Updates_from_Movement_Strategy
  3. Notice that there’s no subscribe link next to the topic title, as it contains no proper signature (the poster of the mass message seems to have used five tildes instead of four).
  4. Now enable both topic subscriptions and topic containers.
  5. Go back to Tgr’s talk page.

Actual result

  1. Notice that the subscribe link appears and seems to be working (but can’t actually work due to the lack of proper signature).

Expected result

  1. Notice that there’s still no subscribe link in that section.

Event Timeline

Change 825420 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix subscribe button appearing for unsubscribeable sections with visualenhancements

https://gerrit.wikimedia.org/r/825420

matmarex added a project: Editing QA.
matmarex moved this task from QA to Code Review on the Editing-team (Kanban Board) board.
matmarex removed a project: Editing QA.

Change 825420 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix subscribe button appearing for unsubscribeable sections with visualenhancements

https://gerrit.wikimedia.org/r/825420

EAkinloose subscribed.

✅ Topic containers shouldn't display subscribe link for unsubscribeable talk page sections

Screenshot 2022-08-26 at 22.58.23.png (714×2 px, 102 KB)

Screenshot 2022-08-26 at 22.58.55.png (634×2 px, 103 KB)

ppelberg claimed this task.