Page MenuHomePhabricator
Create Task
Maniphest T315892

PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed.
Closed, ResolvedPublic
Actions

Description

 There were 41 errors:
16:51:19 
16:51:19 1) Wikibase\Lexeme\Tests\Merge\LexemeMergerTest::testGivenMergingExceptionWhileMergingForms_exceptionBubblesUp
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/composer/Merge/LexemeMergerTest.php:931
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/composer/Merge/LexemeMergerTest.php:588
16:51:19 
16:51:19 2) Wikibase\Lexeme\Tests\Merge\LexemeMergerTest::testGivenOtherException_exceptionIsConvertedToModificationFailedException
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/composer/Merge/LexemeMergerTest.php:931
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/composer/Merge/LexemeMergerTest.php:616
16:51:19 
16:51:19 3) Wikibase\Lexeme\Tests\Merge\LexemeMergerTest::testGivenMergingExceptionWhileMergingSenses_exceptionBubblesUp
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/composer/Merge/LexemeMergerTest.php:931
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/composer/Merge/LexemeMergerTest.php:840
16:51:19 
16:51:19 4) Wikibase\Lexeme\Tests\Merge\MergeLexemesInteractorTest::testGivenMergeSucceeds_targetIsChangedCorrectly
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/composer/Merge/MergeLexemesInteractorTest.php:147
16:51:19 
16:51:19 5) Wikibase\Lexeme\Tests\MediaWiki\Store\FormRevisionLookupTest::testGivenFormId_getLatestRevisionIdCallsToParentServiceWithLexemeId
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Store/FormRevisionLookupTest.php:100
16:51:19 
16:51:19 6) Wikibase\Lexeme\Tests\MediaWiki\Store\FormRevisionLookupTest::testGivenNotExistingFormId_getLatestRevisionIdReturnsNonexistentRevision
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Store/FormRevisionLookupTest.php:119
16:51:19 
16:51:19 7) Wikibase\Lexeme\Tests\MediaWiki\Store\SenseRevisionLookupTest::testGivenSenseId_getLatestRevisionIdCallsToParentServiceWithLexemeId
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Store/SenseRevisionLookupTest.php:99
16:51:19 
16:51:19 8) Wikibase\Lexeme\Tests\MediaWiki\Store\SenseRevisionLookupTest::testLexemeDoesNotContainTheSense_getLatestRevisionIdReturnsNonexistentEntity
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Store/SenseRevisionLookupTest.php:117
16:51:19 
16:51:19 9) Wikibase\Lexeme\Tests\MediaWiki\View\FormsViewTest::testHtmlContainsTheFormsHeadline
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:187
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:33
16:51:19 
16:51:19 10) Wikibase\Lexeme\Tests\MediaWiki\View\FormsViewTest::testHtmlContainsFormsContainer
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:187
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:49
16:51:19 
16:51:19 11) Wikibase\Lexeme\Tests\MediaWiki\View\FormsViewTest::testHtmlContainsFormRepresentationWithIdAndLanguage
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:187
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:61
16:51:19 
16:51:19 12) Wikibase\Lexeme\Tests\MediaWiki\View\FormsViewTest::testHtmlContainsFormId
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:187
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:88
16:51:19 
16:51:19 13) Wikibase\Lexeme\Tests\MediaWiki\View\FormsViewTest::testHtmlContainsFormGrammaticalFeatures
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:187
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:103
16:51:19 
16:51:19 14) Wikibase\Lexeme\Tests\MediaWiki\View\FormsViewTest::testHtmlContainsStatementSection
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:187
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:116
16:51:19 
16:51:19 15) Wikibase\Lexeme\Tests\MediaWiki\View\FormsViewTest::testGrammaticalFeaturesOrder
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/View/FormsViewTest.php:149
16:51:19 
16:51:19 16) Wikibase\Repo\Tests\ChangeOp\ChangeOpsTest::testApply_HasTwoChangeOps_DoesNotPassSummaryObject
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php:227
16:51:19 
16:51:19 17) Wikibase\Repo\Tests\ChangeOp\ChangeOpsTest::testApply_HasOneChangeOp_PassesSummaryObject
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php:241
16:51:19 
16:51:19 18) Wikibase\Repo\Tests\ChangeOp\ChangeOpsTest::testApply_HasTwoChangeOps_SetsGenericSummaryMessage
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php:255
16:51:19 
16:51:19 19) Wikibase\Repo\Tests\ChangeOp\ChangeOpsTest::testApply_HasZeroChangeOps_DoesNotUpdateSummaryAction
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php:271
16:51:19 
16:51:19 20) Wikibase\Repo\Tests\Store\Sql\TypeDispatchingWikiPageEntityMetaDataAccessorTest::testValidConstruction
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessorTest.php:31
16:51:19 
16:51:19 21) Wikibase\Repo\Tests\Store\Sql\TypeDispatchingWikiPageEntityMetaDataAccessorTest::testLoadRevisionInformationDispatching
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessorTest.php:47
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessorTest.php:54
16:51:19 
16:51:19 22) Wikibase\Repo\Tests\Store\Sql\TypeDispatchingWikiPageEntityMetaDataAccessorTest::testLoadRevisionInformationByRevisionId
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessorTest.php:47
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessorTest.php:86
16:51:19 
16:51:19 23) Wikibase\Repo\Tests\Store\Sql\TypeDispatchingWikiPageEntityMetaDataAccessorTest::testLoadLatestRevisionIdsDispatching
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessorTest.php:47
16:51:19 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessorTest.php:115
16:51:19 
16:51:19 24) Wikibase\Lib\Tests\Modules\SettingsValueProviderTest::testGetValueReturnsSettingWithGivenName
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Modules/SettingsValueProviderTest.php:31
16:51:19 
16:51:19 25) Wikibase\Lib\Tests\SimpleCacheWithBagOStuffTest::testGet_GivenSignatureIsWrong_LoggsTheEvent
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/SimpleCacheWithBagOStuffTest.php:112
16:51:19 
16:51:19 26) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenNoLabelInCache_getLabelPassesRequestToInnerLookup
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 27) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGetLabelWritesLabelToCache
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 28) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenEntryInCacheExists_getLabelUsesCachedValue
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 29) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenNoLabelFound_nullEntryWrittenToCache
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 30) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenNullEntryInCache_getLabelReturnsCachedNull
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 31) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenEmptyLanguageCodes_getLabelReturnsNull
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 32) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenNoDescriptionInCache_getDescriptionPassesRequestToInnerLookup
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 33) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGetDescriptionWritesDescriptionToCache
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 34) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenEntryInCacheExists_getDescriptionUsesCachedValue
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 35) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenNoDescriptionFound_nullEntryWrittenToCache
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 36) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenNullEntryInCache_getDescriptionReturnsCachedNull
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 37) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testGivenEmptyLanguageCodes_getDescriptionReturnsNull
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 38) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testNoRevisionFoundForTheEntity_ReturnsNull
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 39) Wikibase\Lib\Tests\Store\CachingFallbackLabelDescriptionLookupTest::testRevisionFoundIsARedirect_UsesLabelFromTargetEntity
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php:40
16:51:19 
16:51:19 40) Wikibase\Lib\Tests\Store\Sql\EntityIdLocalPartPageTableEntityQueryUnitTest::testSelectRowsSimple_noSlottedEntities
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/Sql/EntityIdLocalPartPageTableEntityQueryUnitTest.php:41
16:51:19 
16:51:19 41) Wikibase\Lib\Tests\Store\Sql\EntityIdLocalPartPageTableEntityQueryUnitTest::testSelectRowsCombination
16:51:19 PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
16:51:19 
16:51:19 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Store/Sql/EntityIdLocalPartPageTableEntityQueryUnitTest.php:91
16:51:19 
16:51:19 ERRORS!
16:51:19 Tests: 26537, Assertions: 92815, Errors: 41, Skipped: 84.

Details

SubjectRepoBranchLines +/-
Revert "composer.json: Pin phpunit to 8.5.28"mediawiki/coremaster+1 -1
composer.json: Pin phpunit to 8.5.28mediawiki/coremaster+1 -1
composer.json: Pin phpunit to 8.5.28mediawiki/coreREL1_38+1 -1
composer.json: Pin phpunit to 8.5.28mediawiki/coreREL1_35+1 -1
composer.json: Pin phpunit to 8.5.28mediawiki/coreREL1_37+1 -1
Require phpspec/prophecymediawiki/extensions/Wikibasemaster+1 -0
composer.json: Pin phpunit to 8.5.28mediawiki/corewmf/1.39.0-wmf.25+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Aug 22 2022, 3:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2022, 3:18 PM
kostajh triaged this task as Unbreak Now! priority.Aug 22 2022, 3:19 PM

Seeing this failing tests across various repos. Example failure: https://integration.wikimedia.org/ci/job/integration-quibble-fullrun-extensions-phpunit/76/console, https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/87059/console

kostajh added a project: Wikidata Lexicographical data.Aug 22 2022, 3:20 PM
Maintenance_bot added a project: Wikidata.Aug 22 2022, 3:29 PM
Michael subscribed.Aug 22 2022, 3:33 PM

Not sure what is going on here. This seems to be somehow some composer issue?

Michael added a comment.Aug 22 2022, 3:53 PM

Looking at an earlier run from today:

10:36:41   - Locking phpdocumentor/type-resolver (1.6.1)
10:36:41   - Locking phpspec/prophecy (v1.15.0)
10:36:41   - Locking phpunit/php-code-coverage (7.0.15)
10:36:41   - Locking phpunit/php-file-iterator (2.0.5)
10:36:41   - Locking phpunit/php-text-template (1.2.1)
10:36:41   - Locking phpunit/php-timer (2.1.3)
10:36:41   - Locking phpunit/php-token-stream (3.1.3)
10:36:41   - Locking phpunit/phpunit (8.5.28)

Whereas one of the logs linked above has:

16:46:45   - Locking phpdocumentor/type-resolver (1.6.1)
16:46:45   - Locking phpunit/php-code-coverage (7.0.15)
16:46:45   - Locking phpunit/php-file-iterator (2.0.5)
16:46:45   - Locking phpunit/php-text-template (1.2.1)
16:46:45   - Locking phpunit/php-timer (2.1.3)
16:46:45   - Locking phpunit/php-token-stream (3.1.3)
16:46:45   - Locking phpunit/phpunit (8.5.29)

phpspec/prophecy is gone and PHPUnit has increased its patch version. Why is that? o.O

Michael added a comment.Aug 22 2022, 3:57 PM

Yep that's it. PHPUnit dropped the dependency on phpspec/prophecy in 8.5.29:

https://github.com/sebastianbergmann/phpunit/blob/b510908362c9f385fcdeaf56c5f3ae7f8f31d5d1/ChangeLog-8.5.md#8529---2022-08-22

It is literally the only change in that patch release worth mentioning.

Michael added a comment.Aug 22 2022, 3:59 PM

Guess this is what happens when one just installs the latest compatible version of one's dependencies without a lock-file in source control. 🤷

How do we fix this?

TheresNoTime merged a task: T315900: wmf-quibble-vendor-mysql-php72-docker: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed..Aug 22 2022, 4:03 PM
TheresNoTime added subscribers: TheresNoTime, Reedy.
kostajh added a comment.Aug 22 2022, 4:04 PM

The fastest way might be to pin to phpunit 8.5.28 in core. An alternative would be for WikibaseLexeme and Wikibase to add phpspec/prophecy to require-dev in their composer.json files?

gerritbot added a comment.Aug 22 2022, 4:06 PM

Change 825373 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825373

gerritbot added a project: Patch-For-Review.Aug 22 2022, 4:06 PM
gerritbot added a comment.Aug 22 2022, 4:08 PM

Change 825374 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Require phpspec/prophecy

https://gerrit.wikimedia.org/r/825374

Michael added a comment.Aug 22 2022, 4:09 PM

Looks good, I'd be fine with merging either one of those if they fix the problem.

Michael added a comment.Aug 22 2022, 4:22 PM
In T315892#8174875, @kostajh wrote:

The fastest way might be to pin to phpunit 8.5.28 in core. An alternative would be for WikibaseLexeme and Wikibase to add phpspec/prophecy to require-dev in their composer.json files?

It seems the require-dev of extensions is not taken into account when running tests in CI?

I'll guess we'll go with your patch for now and then come up with something more sustainable.

TheresNoTime added a comment.Aug 22 2022, 4:23 PM

I've just +2'd https://gerrit.wikimedia.org/r/c/mediawiki/core/+/825373/ to get things back & working at least

Michael added a comment.Aug 22 2022, 4:27 PM
In T315892#8174988, @TheresNoTime wrote:

I've just +2'd https://gerrit.wikimedia.org/r/c/mediawiki/core/+/825373/ to get things back & working at least

Thanks!

Nikerabbit subscribed.Aug 22 2022, 4:29 PM
gerritbot added a comment.Aug 22 2022, 4:40 PM

Change 825373 merged by jenkins-bot:

[mediawiki/core@master] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825373

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 22 2022, 5:00 PM
WMDE-leszek subscribed.Aug 22 2022, 5:43 PM
WMDE-leszek added a comment.Aug 22 2022, 7:53 PM
In T315892#8174986, @Michael wrote:
In T315892#8174875, @kostajh wrote:

The fastest way might be to pin to phpunit 8.5.28 in core. An alternative would be for WikibaseLexeme and Wikibase to add phpspec/prophecy to require-dev in their composer.json files?

It seems the require-dev of extensions is not taken into account when running tests in CI?

I'll guess we'll go with your patch for now and then come up with something more sustainable.

Indeed, I believe the way WMF Jenkins CI is set up require all "dev dependencies" that are needed to run tests on Jenkins CI jobs to be defined in require-dev of mediawiki itself.

WMDE-leszek lowered the priority of this task from Unbreak Now! to High.Aug 22 2022, 7:57 PM

Boldly reducing the priority given the bandaid fix has worked.

gerritbot added a comment.Aug 22 2022, 8:14 PM

Change 825281 had a related patch set uploaded (by Urbanecm; author: Kosta Harlan):

[mediawiki/core@wmf/1.39.0-wmf.25] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825281

gerritbot added a comment.Aug 22 2022, 8:32 PM

Change 825281 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.25] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825281

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 22 2022, 9:00 PM
Michael mentioned this in T315966: Handle dependency on phpspec/prophecy.Aug 23 2022, 8:41 AM
Michael added a parent task: T315966: Handle dependency on phpspec/prophecy.
gerritbot added a comment.Aug 23 2022, 9:09 AM

Change 825687 had a related patch set uploaded (by Urbanecm; author: Kosta Harlan):

[mediawiki/core@REL1_38] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825687

gerritbot added a comment.Aug 23 2022, 9:12 AM

Change 825374 abandoned by Michael Große:

[mediawiki/extensions/Wikibase@master] Require phpspec/prophecy

Reason:

require-dev dependencies are not available in WMF CI Jenkins, so this approach doesn't work.

https://gerrit.wikimedia.org/r/825374

gerritbot added a comment.Aug 23 2022, 9:12 AM

Change 825688 had a related patch set uploaded (by Reedy; author: Kosta Harlan):

[mediawiki/core@REL1_37] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825688

gerritbot added a comment.Aug 23 2022, 9:13 AM

Change 825689 had a related patch set uploaded (by Reedy; author: Kosta Harlan):

[mediawiki/core@REL1_35] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825689

gerritbot added a comment.Aug 23 2022, 9:30 AM

Change 825688 merged by jenkins-bot:

[mediawiki/core@REL1_37] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825688

ReleaseTaggerBot added a project: MW-1.37-notes.Aug 23 2022, 10:01 AM
gerritbot added a comment.Aug 24 2022, 8:45 AM

Change 825689 merged by jenkins-bot:

[mediawiki/core@REL1_35] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825689

ReleaseTaggerBot added a project: MW-1.35-notes.Aug 24 2022, 9:00 AM
gerritbot added a comment.Aug 25 2022, 9:20 AM

Change 825687 merged by Jforrester:

[mediawiki/core@REL1_38] composer.json: Pin phpunit to 8.5.28

https://gerrit.wikimedia.org/r/825687

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2022, 9:30 AM
ReleaseTaggerBot added a project: MW-1.38-notes.Aug 25 2022, 10:00 AM
gerritbot added a comment.Sep 23 2022, 9:42 AM

Change 833825 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Revert "composer.json: Pin phpunit to 8.5.28"

https://gerrit.wikimedia.org/r/833825

gerritbot added a project: Patch-For-Review.Sep 23 2022, 9:42 AM
Lucas_Werkmeister_WMDE subscribed.Sep 23 2022, 9:42 AM

It should be okay to unpin PHPUnit on master now; if we want to unpin it on the release branches, we’ll need to backport the prophecy removals first.

Michael added a comment.Sep 23 2022, 9:48 AM
In T315892#8255300, @Lucas_Werkmeister_WMDE wrote:

It should be okay to unpin PHPUnit on master now; if we want to unpin it on the release branches, we’ll need to backport the prophecy removals first.

IMHO, unpinning on master should be good enough. Though, I wonder if we maybe want to keep the minor version pinned? I have slight hopes that they won't break backwards compatibility in patch versions, but only minor ones.

What would be the benefit from also unpinning it on the release branches?

gerritbot added a comment.Sep 23 2022, 11:14 AM

Change 833825 merged by jenkins-bot:

[mediawiki/core@master] Revert "composer.json: Pin phpunit to 8.5.28"

https://gerrit.wikimedia.org/r/833825

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2022, 11:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 23 2022, 12:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 4 2022, 10:21 AM
Lucas_Werkmeister_WMDE claimed this task.

I think we can close this task, PHPUnit is now unpinned again (^8.5) as it was before on master. (Whether it should be unpinned can be discussed elsewhere.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL