Page MenuHomePhabricator

Realtime preview "reload" button overlays the "expand" on a right aligned collapse link
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The "reload" button gets in the way

What should have happened instead?:
You are (somehow) able to expand that collapsable navbar

Other information (browser name/version, screenshots, etc.):

firefox_Y0yOw0vc5S.gif (615×810 px, 166 KB)

Event Timeline

Could we perhaps move the reload button up into the toolbar to be next to the toggle button? e.g.

image.png (85×244 px, 3 KB)

@JSengupta-WMF Do you think moving the button to the toolbar is good? And should we disable the reload button when the preview is closed, or hide it completely?

Let's move the reload button to the left of the preview button. On toggle the reload button can disappear.

Change #1147913 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Move realtime preview reload button into toolbar

https://gerrit.wikimedia.org/r/1147913

Test wiki created on Patch demo by Samwilson using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/e3f0500dd0/w/

Change #1147913 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Move realtime preview reload button into toolbar

https://gerrit.wikimedia.org/r/1147913

Test wiki on Patch demo by Samwilson using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/e3f0500dd0/w/