Page MenuHomePhabricator
Create Task
Maniphest T315895

Suppress button when no results
Closed, ResolvedPublic
Actions

Description

Should we suppress "View" button when there are no results? (How much overhead does this add to make a call on every page load?)

Related Objects

Event Timeline

Dominicbm created this task.Aug 22 2022, 3:24 PM
SuperHamster subscribed.Aug 29 2022, 2:15 AM

I've updated the user script to show the number of results: https://phabricator.wikimedia.org/T316491

An API call is made to fetch the number of hits without returning any results, limiting cost and payload size.

If there are no results, the tab will currently show View (0). We could stick with this, or remove the tab completely. I am leaning towards showing (0); it indicates to the user there are no results, which can be useful to know over hiding the tab altogether.

Dominicbm closed this task as Declined.Oct 18 2022, 9:56 PM

I am going to decline this now, as T317217 resolves the issue, unless we get a request to handle it this way.

Dominicbm changed the task status from Declined to Resolved.Oct 18 2022, 10:23 PM
Dominicbm moved this task from Backlog to Done on the View-it! board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL