Maniphest T315938

Update Echo to use the new HookContainer/HookRunner system
Closed, ResolvedPublic
Actions

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

Create HookRunner class and the hook handler interfaces
Use hook handlers

Details

	Subject	Repo	Branch	Lines +/-
	Use HookHandlers for UserMerge hook	mediawiki/extensions/Echo	master	+131 -107
	Create HookRunner class and the hook handler interfaces	mediawiki/extensions/Echo	master	+428 -23
	Use HookHandlers for remaining core hooks	mediawiki/extensions/Echo	master	+124 -110
	Convert 5 hook subscribers to HookHandlers	mediawiki/extensions/Echo	master	+45 -22
	Convert 10 hook subscribers to HookHandlers	mediawiki/extensions/Echo	master	+41 -23
	Convert 9 hooks subscribers to HookHandlers	mediawiki/extensions/Echo	master	+45 -22

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Umherirrender	T335536 Hard deprecate class Hooks with all deprecated functions (and remove in 1.42)
		Open		None	T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system
		Open		None	T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system
		Open		None	T263364 Update all tarballed extensions to use the new HookContainer/HookRunner system
		Resolved		Etonkovidova	T315938 Update Echo to use the new HookContainer/HookRunner system

Event Timeline

Reedy created this task.Aug 22 2022, 10:30 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 22 2022, 10:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 825417 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Convert 10 hooks subscribers to HookHandlers

https://gerrit.wikimedia.org/r/825417

gerritbot added a project: Patch-For-Review.Aug 22 2022, 10:31 PM

Change 825419 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Convert 5 hook subscribers to HookHandlers

https://gerrit.wikimedia.org/r/825419

Change 825421 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Convert 10 hook subscribers to HookHandlers

https://gerrit.wikimedia.org/r/825421

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Aug 26 2022, 7:26 AM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh moved this task from Code Review to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 16 2022, 12:45 PM

kostajh moved this task from Blocked / Needs work to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 1 2022, 8:46 PM

Change 825417 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Convert 9 hooks subscribers to HookHandlers

https://gerrit.wikimedia.org/r/825417

Change 825419 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Convert 5 hook subscribers to HookHandlers

https://gerrit.wikimedia.org/r/825419

Change 825421 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Convert 10 hook subscribers to HookHandlers

https://gerrit.wikimedia.org/r/825421

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2022, 9:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 1 2022, 10:00 PM

Tgr moved this task from Code Review to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 17 2022, 3:17 AM

Etonkovidova closed this task as Resolved.Dec 9 2022, 5:23 PM

Etonkovidova claimed this task.

Change 927790 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Create HookRunner class and the hook handler interfaces

https://gerrit.wikimedia.org/r/927790

gerritbot added a project: Patch-For-Review.Jun 6 2023, 9:02 PM

Umherirrender reopened this task as Open.Jun 8 2023, 11:50 AM

Umherirrender updated the task description. (Show Details)

Umherirrender mentioned this in T338454: Update GrowthExperiments to use the new HookContainer/HookRunner system.Jun 8 2023, 12:41 PM

Umherirrender added a parent task: T263364: Update all tarballed extensions to use the new HookContainer/HookRunner system.Jun 8 2023, 12:54 PM

Etonkovidova closed this task as Resolved.Jun 27 2023, 9:37 PM

Change 949062 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Use HookHandlers for remaining core hooks

https://gerrit.wikimedia.org/r/949062

Change 949118 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Use HookHandlers for UserMerge hook

https://gerrit.wikimedia.org/r/949118

Umherirrender mentioned this in T344297: Update LoginNotify to use the new HookContainer/HookRunner system.Aug 15 2023, 10:33 PM

Change 949062 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Use HookHandlers for remaining core hooks

https://gerrit.wikimedia.org/r/949062

Change 927790 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Create HookRunner class and the hook handler interfaces

https://gerrit.wikimedia.org/r/927790

Change 949118 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Use HookHandlers for UserMerge hook

https://gerrit.wikimedia.org/r/949118

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2023, 6:10 AM

Umherirrender updated the task description. (Show Details)Aug 16 2023, 6:41 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 5:10 PM

Umherirrender mentioned this in T338450: Update StructuredDiscussions (Flow) to use the new HookContainer/HookRunner system.Sep 16 2023, 10:16 PM

Umherirrender mentioned this in T346507: Update FlaggedRevs to use the new HookContainer/HookRunner system.Sep 16 2023, 10:21 PM

Umherirrender mentioned this in T346509: Update Newsletter to use the new HookContainer/HookRunner system.Sep 16 2023, 10:31 PM

Umherirrender mentioned this in T346511: Update CampaignEvents to use the new HookContainer/HookRunner system.Sep 16 2023, 10:34 PM

Umherirrender mentioned this in T346528: Update BounceHandler to use the new HookContainer/HookRunner system.Sep 16 2023, 11:48 PM

Umherirrender mentioned this in T346536: Update ContentTranslation to use the new HookContainer/HookRunner system.Sep 16 2023, 11:51 PM

Umherirrender mentioned this in T346548: Update ImageSuggestions to use the new HookContainer/HookRunner system.Sep 16 2023, 11:58 PM

Umherirrender mentioned this in T346551: Update MachineVision to use the new HookContainer/HookRunner system.

Umherirrender mentioned this in T346552: Update MassMessage to use the new HookContainer/HookRunner system.Sep 17 2023, 12:01 AM

Umherirrender mentioned this in T315908: Update OAuth to use the new HookContainer/HookRunner system.Sep 17 2023, 12:07 AM

Umherirrender mentioned this in T346556: Update PageTriage to use the new HookContainer/HookRunner system.Sep 17 2023, 12:11 AM

Umherirrender mentioned this in T346566: Update TheWikipediaLibrary to use the new HookContainer/HookRunner system.Sep 17 2023, 12:16 AM

Umherirrender mentioned this in T346567: Update TranslationNotifications to use the new HookContainer/HookRunner system.