Page MenuHomePhabricator
Create Task
Maniphest T315966

Handle dependency on phpspec/prophecy
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

In Wikibase and WikibaseLexeme we are using TestCase::prophesize() from phpspec/prophecy. This used to come automatically with PHPUnit. However with PHPUnit patch release 8.5.29, its dependency phpspec/prophecy was dropped, breaking backward compatibility. This caused the UBN T315892: PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed.. This was mitigated by pinning PHPUnit to 8.25.28 for now.

We need to figure out how to enable us to upgrade PHPUnit properly again.

Possible ways forward:

  • adding phpspec/prophecy as a proper MediaWiki core require-dev composer dependency
  • reworking our tests to no longer use that prophecy functionality
  • ?

Acceptance Criteria:

  • We are able to unpin and update PHPUnit to a version above 8.25.28 without causing CI breaks

Open Questions:

  • Is this prophecy functionality actually good and maintainable and we want to use it, or is it something we would like to get rid of?

Details

SubjectRepoBranchLines +/-
Stop using prophecy in SidebarLinkBadgeDisplayTestmediawiki/extensions/WikibaseREL1_39+14 -8
Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTestmediawiki/extensions/WikibaseREL1_39+18 -15
Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTestmediawiki/extensions/WikibaseREL1_39+28 -30
Stop using prophecy in WikibaseValueFormatterBuildersTestmediawiki/extensions/WikibaseREL1_39+1 -1
Stop using prophecy in WikiPageEntityStoreTestmediawiki/extensions/WikibaseREL1_39+13 -10
Remove instances of prophecy library in Wikibasemediawiki/extensions/WikibaseREL1_39+175 -155
Stop using prophecy in ItemPropertyIdHtmlLinkFormatterTestmediawiki/extensions/WikibaseREL1_39+73 -64
Stop using prophecy in WikiPageEntityRevisionLookupTestmediawiki/extensions/WikibaseREL1_39+27 -32
Stop using prophecy in testsmediawiki/extensions/WikibaseLexemeREL1_39+44 -48
Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTestmediawiki/extensions/WikibaseREL1_39+45 -52
Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTestmediawiki/extensions/Wikibasemaster+28 -30
Stop using prophecy in SidebarLinkBadgeDisplayTestmediawiki/extensions/Wikibasemaster+14 -8
Stop using prophecy in WikibaseValueFormatterBuildersTestmediawiki/extensions/Wikibasemaster+1 -1
Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTestmediawiki/extensions/Wikibasemaster+45 -52
Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTestmediawiki/extensions/Wikibasemaster+18 -15
Stop using prophecy in WikiPageEntityStoreTestmediawiki/extensions/Wikibasemaster+13 -10
Remove instances of prophecy library in Wikibasemediawiki/extensions/Wikibasemaster+175 -155
Stop using prophecy in testsmediawiki/extensions/WikibaseLexememaster+44 -48
Stop using prophecy in WikiPageEntityRevisionLookupTestmediawiki/extensions/Wikibasemaster+27 -32
Stop using prophecy in ItemPropertyIdHtmlLinkFormatterTestmediawiki/extensions/Wikibasemaster+73 -64
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Aug 23 2022, 8:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2022, 8:41 AM
Michael added a subtask: T315892: PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed..Aug 23 2022, 8:42 AM
Maintenance_bot added a project: Wikidata.Aug 23 2022, 8:45 AM
kostajh subscribed.Aug 23 2022, 8:54 AM

Removing its usage seems like a reasonable way forward, IMHO, based on the low usage across repos and the commentary in https://github.com/sebastianbergmann/phpunit/issues/5033.

Michael updated the task description. (Show Details)Aug 23 2022, 9:14 AM
ItamarWMDE added a project: wmde-wikidata-tech.Aug 23 2022, 9:38 AM
Maintenance_bot moved this task from Inbox to Sorted Team A on the [DEPRECATED] wdwb-tech board.Aug 23 2022, 10:15 AM
ItamarWMDE moved this task from Incoming to [DOT] Prioritized on the wmde-wikidata-tech board.Aug 23 2022, 10:56 AM
ItamarWMDE added a project: Wikidata Dev Team.
ItamarWMDE renamed this task from Figure out what to do with phpspec/prophecy to Handle dependency on phpspec/prophecy.Aug 23 2022, 10:59 AM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE subscribed.

Prio Notes:

  • Does not affect end users
  • Might affect external stakeholders (breaking change caused a UBN)
  • Affects development efforts (we cannot update our dependencies without resolving this)
  • Does not affect onboarding efforts
WMDE-leszek subscribed.Aug 23 2022, 1:15 PM
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.Aug 24 2022, 8:17 AM
Lucas_Werkmeister_WMDE subscribed.Aug 31 2022, 12:48 PM

I also vote for getting rid of prophesize(). At a glance, it doesn’t look like we use it for anything that createMock() or getMockBuilder() can’t do – as far as I’m aware, it’s just an older way of doing the same job.

ItamarWMDE moved this task from [DOT] Tech Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Aug 31 2022, 2:01 PM
gerritbot added a comment.Sep 9 2022, 4:14 PM

Change 831123 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/831123

gerritbot added a project: Patch-For-Review.Sep 9 2022, 4:14 PM
Lucas_Werkmeister_WMDE added a comment.Sep 9 2022, 4:15 PM

I tried converting one class to see if there would be any issues, and it mostly went smoothly, but there are a few differences. See the commit message of the above change for details.

(I still think we can get rid of prophesize() without too much trouble, though.)

guergana.tzatchkova moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.Sep 12 2022, 11:45 AM
guergana.tzatchkova edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
guergana.tzatchkova moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.
guergana.tzatchkova claimed this task.Sep 12 2022, 11:47 AM
gerritbot added a comment.Sep 12 2022, 12:12 PM

Change 831123 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/831123

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2022, 12:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 12 2022, 1:00 PM
guergana.tzatchkova set the point value for this task to 5.Sep 12 2022, 4:48 PM
gerritbot added a comment.Sep 14 2022, 3:11 PM

Change 832274 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in WikiPageEntityRevisionLookupTest

https://gerrit.wikimedia.org/r/832274

gerritbot added a project: Patch-For-Review.Sep 14 2022, 3:11 PM

Change 832275 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Stop using prophecy in tests

https://gerrit.wikimedia.org/r/832275

gerritbot added a comment.Sep 15 2022, 1:21 PM

Change 832496 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/Wikibase@master] Remove instances of prophecy library in Wikibase

https://gerrit.wikimedia.org/r/832496

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Sep 15 2022, 1:37 PM
gerritbot added a comment.Sep 15 2022, 3:07 PM

Change 832274 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in WikiPageEntityRevisionLookupTest

https://gerrit.wikimedia.org/r/832274

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.2; 2022-09-19); removed MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 15 2022, 4:00 PM
gerritbot added a comment.Sep 21 2022, 9:22 AM

Change 832275 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Stop using prophecy in tests

https://gerrit.wikimedia.org/r/832275

gerritbot added a comment.Sep 21 2022, 9:50 AM

Change 833737 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in WikiPageEntityStoreTest

https://gerrit.wikimedia.org/r/833737

gerritbot added a comment.Sep 21 2022, 9:53 AM

Change 832496 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove instances of prophecy library in Wikibase

https://gerrit.wikimedia.org/r/832496

gerritbot added a comment.Sep 21 2022, 9:57 AM

Change 833739 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTest

https://gerrit.wikimedia.org/r/833739

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.3; 2022-09-26); removed MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 21 2022, 10:00 AM
gerritbot added a comment.Sep 21 2022, 10:31 AM

Change 833744 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTest

https://gerrit.wikimedia.org/r/833744

gerritbot added a comment.Sep 21 2022, 10:38 AM

Change 833748 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTest

https://gerrit.wikimedia.org/r/833748

gerritbot added a comment.Sep 21 2022, 10:42 AM

Change 833749 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in WikibaseValueFormatterBuildersTest

https://gerrit.wikimedia.org/r/833749

gerritbot added a comment.Sep 21 2022, 10:44 AM

Change 833750 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using prophecy in SidebarLinkBadgeDisplayTest

https://gerrit.wikimedia.org/r/833750

gerritbot added a comment.Sep 21 2022, 12:05 PM

Change 833737 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in WikiPageEntityStoreTest

https://gerrit.wikimedia.org/r/833737

gerritbot added a comment.Sep 21 2022, 12:11 PM

Change 833744 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTest

https://gerrit.wikimedia.org/r/833744

gerritbot added a comment.Sep 21 2022, 12:13 PM

Change 833748 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTest

https://gerrit.wikimedia.org/r/833748

gerritbot added a comment.Sep 21 2022, 12:14 PM

Change 833749 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in WikibaseValueFormatterBuildersTest

https://gerrit.wikimedia.org/r/833749

gerritbot added a comment.Sep 21 2022, 12:39 PM

Change 833750 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in SidebarLinkBadgeDisplayTest

https://gerrit.wikimedia.org/r/833750

guergana.tzatchkova moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Sep 21 2022, 3:55 PM
gerritbot added a comment.Sep 21 2022, 4:26 PM

Change 833739 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTest

https://gerrit.wikimedia.org/r/833739

ItamarWMDE added a comment.Sep 22 2022, 4:54 PM

\o/ Merged patches look great, running codesearch on our repos for "prophesize" yields no results: Good Job!

ItamarWMDE closed this task as Resolved.Sep 22 2022, 4:54 PM
ItamarWMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Oct 4 2022, 9:14 AM
Lucas_Werkmeister_WMDE closed subtask T315892: PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. as Resolved.Oct 4 2022, 10:21 AM
gerritbot added a comment.Sep 2 2023, 12:11 PM

Change 954237 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@REL1_39] Stop using prophecy in tests

https://gerrit.wikimedia.org/r/954237

gerritbot added a comment.Sep 2 2023, 12:11 PM

Change 954238 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTest

https://gerrit.wikimedia.org/r/954238

gerritbot added a comment.Sep 2 2023, 12:35 PM

Change 954238 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTest

https://gerrit.wikimedia.org/r/954238

gerritbot added a comment.Sep 2 2023, 12:36 PM

Change 954237 merged by Reedy:

[mediawiki/extensions/WikibaseLexeme@REL1_39] Stop using prophecy in tests

https://gerrit.wikimedia.org/r/954237

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953500 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/953500

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953501 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in WikiPageEntityRevisionLookupTest

https://gerrit.wikimedia.org/r/953501

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953502 had a related patch set uploaded (by Reedy; author: Guergana Tzatchkova):

[mediawiki/extensions/Wikibase@REL1_39] Remove instances of prophecy library in Wikibase

https://gerrit.wikimedia.org/r/953502

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953503 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in WikiPageEntityStoreTest

https://gerrit.wikimedia.org/r/953503

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953504 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTest

https://gerrit.wikimedia.org/r/953504

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953505 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTest

https://gerrit.wikimedia.org/r/953505

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 954366 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in WikibaseValueFormatterBuildersTest

https://gerrit.wikimedia.org/r/954366

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 954367 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in SidebarLinkBadgeDisplayTest

https://gerrit.wikimedia.org/r/954367

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953500 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/953500

gerritbot added a comment.Sep 2 2023, 12:41 PM

Change 953501 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in WikiPageEntityRevisionLookupTest

https://gerrit.wikimedia.org/r/953501

gerritbot added a comment.Sep 2 2023, 12:42 PM

Change 953502 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Remove instances of prophecy library in Wikibase

https://gerrit.wikimedia.org/r/953502

gerritbot added a comment.Sep 2 2023, 12:42 PM

Change 953503 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in WikiPageEntityStoreTest

https://gerrit.wikimedia.org/r/953503

gerritbot added a comment.Sep 2 2023, 12:42 PM

Change 953504 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTest

https://gerrit.wikimedia.org/r/953504

gerritbot added a comment.Sep 2 2023, 12:42 PM

Change 953505 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTest

https://gerrit.wikimedia.org/r/953505

gerritbot added a comment.Sep 2 2023, 12:42 PM

Change 954366 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in WikibaseValueFormatterBuildersTest

https://gerrit.wikimedia.org/r/954366

gerritbot added a comment.Sep 2 2023, 12:56 PM

Change 954367 merged by Reedy:

[mediawiki/extensions/Wikibase@REL1_39] Stop using prophecy in SidebarLinkBadgeDisplayTest

https://gerrit.wikimedia.org/r/954367

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2023, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL