Page MenuHomePhabricator

When loading another person's recent comment, reply box disappears and becomes un-openable
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Other person's reply is loaded
  • Your reply textarea disappears
  • Reply textarea cannot be re-opened because all "reply" links are still disabled
  • Console error:
Uncaught TypeError: Cannot read properties of null (reading 'getModel')
    at ReplyWidgetVisual.getValue (<anonymous>:241:126)
    at ReplyWidget.preparePreview (<anonymous>:379:577)
    at ReplyWidget.onInputChange (<anonymous>:379:371)
    at run (load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core%7Cjquery.ui&skin=vector&version=1jdns:439:633)

What should have happened instead?:

  • Other person's reply is loaded
  • Either your reply remains open and in progress, or your reply is hidden but the "reply" links are re-enabled

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

I can reproduce, it seems there are additional requirements to trigger the bug:

  • You must be using the tool in wikitext mode with the toolbar enabled
  • You must click the button to show new comments very quickly after typing, while the live preview is still updating to show what you just typed

Change 826404 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Clear pending updates when tearing down

https://gerrit.wikimedia.org/r/826404

Change 826404 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Ignore pending updates after tearing down

https://gerrit.wikimedia.org/r/826404