Page MenuHomePhabricator

Underscore displayed in namespace prefix for non-existent pages (e.g. "User_talk")
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Screenshots from Vector skin, but other skins have this issue too:

User_talk with underscore.png (289×1 px, 51 KB)

User_talk without underscore 1.png (297×1 px, 53 KB)

User_talk without underscore 2.png (267×928 px, 44 KB)

What should have happened instead?:
Underscore should not have been displayed in first screenshot.

Event Timeline

matmarex edited projects, added DiscussionTools; removed Talk Pages.

It seems to be. It turns out that Title::getNsText() returns the namespace name with underscores, not spaces, unlike every other Title method with "text" in its name. Weird that it only affects IPs and not registered users.

Weird that it only affects IPs and not registered users.

Never mind, I can reproduce for unregistered users too, but the user's talk page must not exist.

Change 826380 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Display page namespace with spaces instead of underscores when page doesn't exist

https://gerrit.wikimedia.org/r/826380

Change 826382 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Document some functions that return namespace name with underscores (not spaces)

https://gerrit.wikimedia.org/r/826382

matmarex renamed this task from Underscore displayed in "User_talk" namespace prefix for IPs to Underscore displayed in namespace prefix for non-existent pages (e.g. "User_talk").Aug 24 2022, 8:43 PM

Change 826380 merged by jenkins-bot:

[mediawiki/core@master] Display page namespace with spaces instead of underscores when page doesn't exist

https://gerrit.wikimedia.org/r/826380

Change 826332 had a related patch set uploaded (by Ladsgroup; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.39.0-wmf.26] Display page namespace with spaces instead of underscores when page doesn't exist

https://gerrit.wikimedia.org/r/826332

Change 826332 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.26] Display page namespace with spaces instead of underscores when page doesn't exist

https://gerrit.wikimedia.org/r/826332

Mentioned in SAL (#wikimedia-operations) [2022-08-25T05:46:10Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.26/includes/page/Article.php: Backport: [[gerrit:826332|Display page namespace with spaces instead of underscores when page doesn't exist (T316092)]] (duration: 03m 32s)

Change 826382 merged by jenkins-bot:

[mediawiki/core@master] docs: Clarify that functions returning namespace names include underscores (not spaces)

https://gerrit.wikimedia.org/r/826382