Handle users with block/permission issues
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	eamedina
	Aug 24 2022, 4:53 PM

Description

Some sort of user validation to treat users with block/permission issues as appropriate. Need to understand what is appropriate for such cases, what are the different types of issues. For example: if a user is blocked from editing an article, what type of create/edit permission should the user have for stories in the article? What about creating/editing in the Story namespace?

Originated from this feedback

Block/Unblock reference

Solution

Display a banner for users with a site-wide or page-specific block when they attempt to create a new Wikistory or edit an existing one.
Not displayed for users with partial blocks that are unrelated to the Wikistory they are working on.
Unlike other banners, can we keep this banner remains visible and does not fade away, providing a constant reminder of the restriction.
Banner message 'Your account is currently restricted from editing or creating a Wikistory.'

QA instructions

In order to test, you can first make sure you have an account with admin rights [1], and then use that admin account to block another testing account using http://localhost:8080/wiki/Special:Block. Only blocked users should see the error notice, I also tested with a partial block where only one article is restricted but others are allowed.

[1] https://www.mediawiki.org/wiki/Manual:FAQ#Initial_user_was_not_created_by_installer_or_it_is_not_an_administrator

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T316131 here

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Show error Notice if user is blocked from current article	mediawiki/extensions/Wikistories	master	+130 -48

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T327899 Wikistories Moderation features
		Resolved		eamedina	T316131 Handle users with block/permission issues

Event Timeline

eamedina created this task.Aug 24 2022, 4:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2022, 4:53 PM

• PWaigi-WMF added a parent task: T318901: Contributor/Reader experience on Wikistories.Sep 29 2022, 5:26 PM

• PWaigi-WMF edited parent tasks, added: T318905: Knowledge Reliability on Wikistories; removed: T318901: Contributor/Reader experience on Wikistories.Sep 29 2022, 5:45 PM

• PWaigi-WMF edited parent tasks, added: T327899: Wikistories Moderation features; removed: T318905: Knowledge Reliability on Wikistories.Jan 25 2023, 1:24 PM

SBisson moved this task from R2 to Backlog on the Wikistories board.May 15 2023, 3:06 PM

SBisson edited projects, added Wikistories; removed Wikistories (R2).

SBisson edited projects, added Inuka-Team (Next); removed Inuka-Team.Jun 13 2023, 7:46 PM

SBisson moved this task from Next to Kanban on the Inuka-Team board.Oct 17 2023, 8:02 PM

SBisson edited projects, added Inuka-Team (Kanban); removed Inuka-Team (Next).

• PWaigi-WMF moved this task from Backlog to Definition on the Inuka-Team (Kanban) board.Oct 19 2023, 2:36 PM

• PWaigi-WMF updated the task description. (Show Details)Nov 15 2023, 3:22 PM

SGautam_WMF updated the task description. (Show Details)Dec 1 2023, 11:41 AM

SGautam_WMF moved this task from Definition to Ready for Dev on the Inuka-Team (Kanban) board.

eamedina claimed this task.Dec 1 2023, 2:38 PM

eamedina triaged this task as Medium priority.

eamedina moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Change 980511 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Show error Notice if user is blocked from current article

https://gerrit.wikimedia.org/r/980511

gerritbot added a project: Patch-For-Review.Dec 6 2023, 12:05 AM

eamedina moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Dec 7 2023, 10:45 PM

eamedina updated the task description. (Show Details)Dec 11 2023, 5:09 PM

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Dec 13 2023, 1:44 PM

Change 980511 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Show error Notice if user is blocked from current article

https://gerrit.wikimedia.org/r/980511

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 13 2023, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 2:12 PM

@eamedina Sitewide and Partial block are working as designed when a username is blocked. Partial block only sees the banner for the article they are blocked with. They are also the only ones that will see the block error notice. When you block an IP address though, you do not get the error even though that's the IP address that should be blocked

Status: ❌ FAIL
Environment: Local: 1.42.0-alpha (7731c6e) 16:24, 8 January 2024
OS: macOS Sonoma 14.2
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. Minvera
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/wiki/Special:StoryBuilder/Story:Dog_Test?frameid=0#story
http://localhost:8080/wiki/Special:StoryBuilder/Story:Cat_Test?frameid=0#story

❌ AC1: https://phabricator.wikimedia.org/T316131

When IP Addressed is blocked - Blocked error does not appear

IP Address

2024-01-08_16-57-54.png (1×1 px, 203 KB)

✅When Username is blocked - Blocked error does appear

Blocks	Sitewide Block	Partial Block
Screenshot
Edit
New Wikistory

**Possible Issues**

Should there be a hard stop when a user is blocked besides letting you able to proceed? You can't save it but wasn't sure if it should even allow you to get further or not as seen in the .webm's below.

Edit

Add

Create

GMikesell-WMF updated the task description. (Show Details)Jan 9 2024, 1:12 AM

SBisson updated the task description. (Show Details)Jan 10 2024, 3:40 PM

When IP Addressed is blocked - Blocked error does not appear

Interesting catch, I hadn't thought of this perspective. After debugging with George, we learned admins can specifically mark whether an IP block should include users who log in with that IP address, so admins can do this if they wish. Either way, anonymous users can't create/edit Wikistories (only view them), they have to log in to create/edit, so from the perspective of the Wikistories extension a username block is all that's needed.

Should there be a hard stop when a user is blocked besides letting you able to proceed?

This is a good point that we previously discussed as a team while developing this feature, we landed on the idea of letting blocked users at least be able to explore Wikistories as much as possible, without being able to publish/save (so the current behavior you're seeing).

@eamedina Ok sounds good. Based on the above and what I got when checking "Apply block to logged-in users from the IP address", I will move this to design sign-off. Thanks for all your work!

Status: ✅ PASS
Environment: Local: 1.42.0-alpha (7731c6e) 16:24, 8 January 2024
OS: macOS Sonoma 14.2
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. Minvera
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/wiki/Special:StoryBuilder/Story:Dog_Test?frameid=0#story
http://localhost:8080/wiki/Special:StoryBuilder/Story:Cat_Test?frameid=0#story

❌ AC1: https://phabricator.wikimedia.org/T316131
When IP Addressed is blocked - Blocked error does not appear

✅ AC1: https://phabricator.wikimedia.org/T316131 - OK as talked about if you check off "Apply block to logged-in users from the IP address", a block error does appear.