Page MenuHomePhabricator
Create Task
Maniphest T316174

[minor-wmf.25] MediaSearch - no input focus for loading empty results page
Closed, ResolvedPublic
Actions

Description

Found when verifying T215117: [S] Don't focus on search input when displaying search results in Special:Search.

  1. As an anon user or a user with MediaSearch set as default, go to any page on commonsw wiki.
  2. Click on the search icon in the Search text box or type there - Special:MediaSearch
  3. Special:MediaSearch page will be displayed - the input field won't have a focus, so a user is not able to start typing.

Note: That MeidaSearch behavior is different from Special:Search. If a user with default Special:Search (or by entering Special:Search in the input field) goes to Special:Search page without any results, the Special:Search page will display the focus in the search input field.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MediaSearchmaster+20 -1MediaSearch - no input focus for loading empty results page
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Aug 24 2022, 11:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2022, 11:39 PM
Etonkovidova mentioned this in T215117: [S] Don't focus on search input when displaying search results in Special:Search.Aug 24 2022, 11:41 PM
CBogen moved this task from Triage to MediaSearch on the Structured-Data-Backlog board.Aug 29 2022, 4:31 PM
Aklapper added a project: SDAW-MediaSearch.Sep 11 2022, 12:15 PM

Assuming this task is about the SDAW-MediaSearch code base, hence adding that project tag so other people who don't know or don't care about teams in some organization can also find this task when searching via projects. Please set appropriate code base project tags. Thanks!

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jan 23 2023, 6:28 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
• StephaneRebai claimed this task.Jan 24 2023, 11:17 AM
• StephaneRebai moved this task from Ready for Estimation to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Jan 24 2023, 1:52 PM

Change 883175 had a related patch set uploaded (by Stephane Rebai; author: Stephane Rebai):

[mediawiki/extensions/MediaSearch@master] T316174 set focus on input when Media:Search loads

https://gerrit.wikimedia.org/r/883175

gerritbot added a project: Patch-For-Review.Jan 24 2023, 1:52 PM
• StephaneRebai added a comment.Jan 27 2023, 6:00 PM

focus added on no-JS context
also added with JS context but needs confirmation before submitting patch

SimoneThisDot claimed this task.Wed, May 10, 8:16 AM
SimoneThisDot added a subscriber: • StephaneRebai.
gerritbot added a comment.Wed, May 10, 10:15 AM

Change 918420 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] MediaSearch - no input focus for loading empty results page

https://gerrit.wikimedia.org/r/918420

gerritbot added a comment.Wed, May 10, 10:17 AM

Change 883175 abandoned by Simone Cuomo:

[mediawiki/extensions/MediaSearch@master] T316174 set focus on input when Media:Search loads

Reason:

A follow up patch has been created to solve this issue

https://gerrit.wikimedia.org/r/883175

SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Wed, May 10, 9:04 PM
gerritbot added a comment.Fri, May 26, 11:05 AM

Change 918420 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] MediaSearch - no input focus for loading empty results page

https://gerrit.wikimedia.org/r/918420

Maintenance_bot removed a project: Patch-For-Review.Fri, May 26, 11:10 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).Fri, May 26, 12:00 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Fri, May 26, 2:13 PM
Etonkovidova closed this task as Resolved.Tue, May 30, 4:04 PM

Checked commons wmf.9 - the issue is fixed.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL