| WMDE-Fisch | |
| Aug 25 2022, 11:24 AM |
| F35519168: Screenshot from 2022-09-13 15-31-47.png | |
| Sep 13 2022, 1:33 PM |
| F35519058: Screenshot from 2022-09-13 13-54-09.png | |
| Sep 13 2022, 11:55 AM |
| F35489674: ErrorMessageSaved.png | |
| Aug 25 2022, 11:24 AM |
User might not know what to put into the marker-color property. When saving the page with a broken color value there's currently a very cryptic error message and the map is just broken.
We could provide a default fallback color, so the map never renders broken.
We might be able to improve the message. See also T304748: Maps GeoJSON errors are reported as missing "query" when this is not the problem
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Show all GeoJSON validation errors | mediawiki/extensions/Kartographer | master | +70 -9 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T148883 Gracefully handle broken ExternalData services | |||
| Open | None | T306533 Improve error handling and messages for maps | |||
| Declined | thiemowmde | T316213 Improve error handling when an invalid marker color is used | |||
| Resolved | thiemowmde | T317873 Improve presentation of GeoJSON+simplestyle JSON Schema validation failure |
Change 826520 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Kartographer@master] Show all GeoJSON validation errors
Personally, I think it's fine to validate color codes as part of the JSON schema validation step. A fallback color might be more confusing than helpful. Let's just show the correct error message, as suggested in https://gerrit.wikimedia.org/r/826520.
Change 826520 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Show all GeoJSON validation errors
We discussed this in demo time and together with UX we came to the conclusion that the more verbose error is less useful than the previous state. We would like to revert this change and instead replace the existing error message with a clearer one - UX will provide the text.
Change 831867 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Kartographer@master] [POC] Show JSON Schema validation log not as red error
For reference, this is what the patch https://gerrit.wikimedia.org/r/831867 does. It's even initially collapsed.
