Page MenuHomePhabricator

[tbs.cli]: Create reasonable defaults for the build command (so the users have to add only the minimum needed info)
Closed, ResolvedPublic2 Estimated Story Points

Description

  • image-name -> change the default to the tool/user running the cli (that is, the user triggering the build, or the tool triggering the build, that is, the uid, os.getusername() might be enough), make it optional to override.
  • dest-repository -> change the default to the tools instance (harbor.tools.wmflabs.org), make it optional to override.

The code to modify for this is the decorators here: https://gerrit.wikimedia.org/r/plugins/gitiles/cloud/toolforge/toolforge-cli/+/refs/heads/main/toolforge_cli/cli.py#238

Event Timeline

bd808 renamed this task from [tbs.cli]: Create sane defaults for the build command (so the users have to add only the minimum needed info) to [tbs.cli]: Create reasonable defaults for the build command (so the users have to add only the minimum needed info).Aug 25 2022, 3:24 PM
Slst2020 triaged this task as Medium priority.
Slst2020 updated Other Assignee, added: dcaro.
Slst2020 added a project: User-Slst2020.
Slst2020 changed the task status from Open to In Progress.Aug 26 2022, 8:04 AM

Change 826788 had a related patch set uploaded (by Slavina Stefanova; author: Slavina Stefanova):

[cloud/toolforge/toolforge-cli@main] cli: Create reasonable defaults for the build command

https://gerrit.wikimedia.org/r/826788

Slst2020 changed the task status from In Progress to Open.Aug 26 2022, 8:21 AM

What is left here? What is blocking you?

What is left here? What is blocking you?

Nothing, the patch just needs merging if it looks good to everyone.

Nothing, the patch just needs merging if it looks good to everyone.

Okok 👍
I see you got a +1 already, feel free to merge :) (I think just adding a +2 might do the trick)

Nothing, the patch just needs merging if it looks good to everyone.

Okok 👍
I see you got a +1 already, feel free to merge :) (I think just adding a +2 might do the trick)

I don't have +2 rights on the repo

Done, you should have access

Change 826788 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] cli: Create reasonable defaults for the build command

https://gerrit.wikimedia.org/r/826788