Page MenuHomePhabricator

Toast covers subscribe button
Open, Needs TriagePublic

Description

  1. Visit a talk page.
  2. Click a section heading in the Table of Contents (so the ==Section heading== is at the top of your screen)
  3. Reply to the first comment (so the ==Section heading== remains at the top of your screen)
  4. See the message pop up about your comment successfully being posted.
  5. Don't see the [subscribe] button changing, because it's covered up by the toast.

ES: Adding screenshot

image.png (576×1 px, 228 KB)

Event Timeline

I agree this is not optimal, but I don't think we were really highlighting the change of state of the subscribe button anyway, and in many cases the subscribe button would be off the top of the screen anyway, so seeing the button change state is not a guaranteed feature.

As I mentioned in T312783#8078730, trying to get notifications to never overlap another important piece of UI is a never-ending game of cat and mouse, and is probably best avoided as the notifications are ephemeral by nature.

Note we currently highlight auto-subscriptions the first time you use them (see below). If we think this needs to happen on subsequent posts then we should address than another way, not by moving the post-edit notification.

image.png (452×998 px, 75 KB)