Page MenuHomePhabricator

Prepare cleanupInvalidDbKeys.php for new linktarget table
Closed, ResolvedPublic

Description

With T299417 the tl_namespace and tl_title fields are removed from templatelinks, but are refered by cleanupInvalidDbKeys.php.

The script should cleanup the new linktarget as well, when something invalid is there

Related Objects

Event Timeline

sigh, that's important because if it's ran on basically any section now and it does a write on the table, it'd break replication to all replicas...

at least as silver lining, it breaks before even getting into deleting stuff.

Change 827978 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] maintenance: Add support for links migration to cleanupInvalidDbKeys

https://gerrit.wikimedia.org/r/827978

Change 827978 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Add support for links migration to cleanupInvalidDbKeys

https://gerrit.wikimedia.org/r/827978

Ladsgroup claimed this task.
Ladsgroup added a project: DBA.

The clean up from linktarget table will happen with a dedicated maint script that removes all orphan linktarget rows. This is done.