Author: colin.pitts
Description:
Special:Undelete displays the oldest deleted revision not the newest.
This behavior is both counter-intuitive and backwards from the existing behavior.
Version: 1.4.x
Severity: normal
| • bzimport | |
| Dec 23 2004, 6:46 AM |
| F1740: SpecialUndelete.php.rel1_4_1.diff | |
| Nov 21 2014, 8:06 PM |
| F1739: SpecialUndelete.php.rel1_5.diff | |
| Nov 21 2014, 8:06 PM |
Author: colin.pitts
Description:
Special:Undelete displays the oldest deleted revision not the newest.
This behavior is both counter-intuitive and backwards from the existing behavior.
Version: 1.4.x
Severity: normal
Created attachment 438
Patch against HEAD
The bug is caused by a string passed instead of an array of options to
selectrow.
Attached:
Applied with slight modification (include the limit; if there are many we only want one here).
Fix in CVS HEAD and REL1_4, will appear in 1.4.3 release
(Note that deletion is a bit borked in HEAD at the moment.)
(In reply to comment #3)
Applied with slight modification (include the limit; if there are many we only
want one here).
Note that this is unnecessary, Database::selectRow specifies LIMIT 1
automatically ("select [one] row").
Ok, time to sleep before any more check-ins. :)
Removed the redundant clause. (It's harmless as it's overridden in selectRow(), not appended, but let's not
needlessly multiply non-parsimonious elements.)