Page MenuHomePhabricator

Special:Undelete shows oldest revision not newest
Closed, ResolvedPublic

Description

Author: colin.pitts

Description:
Special:Undelete displays the oldest deleted revision not the newest.

This behavior is both counter-intuitive and backwards from the existing behavior.


Version: 1.4.x
Severity: normal

Details

Reference
bz1163

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:06 PM
bzimport set Reference to bz1163.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 438
Patch against HEAD

The bug is caused by a string passed instead of an array of options to
selectrow.

Attached:

Created attachment 439
Patch against REL1_4_1

Attached:

Applied with slight modification (include the limit; if there are many we only want one here).

Fix in CVS HEAD and REL1_4, will appear in 1.4.3 release

(Note that deletion is a bit borked in HEAD at the moment.)

(In reply to comment #3)

Applied with slight modification (include the limit; if there are many we only

want one here).

Note that this is unnecessary, Database::selectRow specifies LIMIT 1
automatically ("select [one] row").

Ok, time to sleep before any more check-ins. :)

Removed the redundant clause. (It's harmless as it's overridden in selectRow(), not appended, but let's not
needlessly multiply non-parsimonious elements.)