Page MenuHomePhabricator
Create Task
Maniphest T316319

🌶️ Handle errors caused by patching
Closed, ResolvedPublic
Actions

Description

  • handle patcher exceptions
  • use StatementSnaksValueTypeValidator to validate the patched statement
  • handle exceptions thrown by StatementList.replace()
  • create PatchItemStatementErrorResponse in case of failure
  • RouteHandler turns use case error into http error response

See story task T306934 for error codes.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Handle errors thrown by StatementPatchermediawiki/extensions/Wikibasemaster+147 -2
REST: Handle patched Property/Statement ID change errorsmediawiki/extensions/Wikibasemaster+100 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE created this task.Aug 26 2022, 8:04 AM
Silvan_WMDE mentioned this in T306934: 🌶️ Change elements of an item statement.Aug 26 2022, 8:08 AM
Jakob_WMDE claimed this task.Sep 9 2022, 9:10 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 12) board.
gerritbot added a comment.Sep 9 2022, 11:21 AM

Change 831069 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Handle patched Property/Statement ID change errors

https://gerrit.wikimedia.org/r/831069

gerritbot added a project: Patch-For-Review.Sep 9 2022, 11:21 AM
gerritbot added a comment.Sep 9 2022, 1:23 PM

Change 831090 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Handle errors thrown by StatementPatcher

https://gerrit.wikimedia.org/r/831090

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 12) board.Sep 12 2022, 8:26 AM
gerritbot added a comment.Sep 12 2022, 1:17 PM

Change 831069 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle patched Property/Statement ID change errors

https://gerrit.wikimedia.org/r/831069

gerritbot added a comment.Sep 12 2022, 1:43 PM

Change 831090 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle errors thrown by StatementPatcher

https://gerrit.wikimedia.org/r/831090

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 12 2022, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 12 2022, 2:30 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 12) board.Sep 13 2022, 9:00 AM
WMDE-leszek closed this task as Resolved.Oct 14 2022, 12:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits