Maniphest T316332

[tbs.buildpack-admission-controller] Ensure we use the deploy.sh standard
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Make sure that the buildpack-admission-controller code (https://github.com/toolforge/buildpack-admission-controller) uses the deploy.sh standard for deployment:
https://wikitech.wikimedia.org/wiki/Wikimedia_Cloud_Services_team/EnhancementProposals/Decision_record_T303931_k8s_standard_deployment_code_pattern

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		LucasWerkmeister	T320140 Migrate wd-shex-infer from Toolforge GridEngine to Toolforge Kubernetes
		Stalled		matmarex	T319707 Migrate dtcheck from Toolforge GridEngine to Toolforge Kubernetes
		Open		None	T320062 Migrate steve-adder from Toolforge GridEngine to Toolforge Kubernetes
		Open		None	T320011 Migrate rfa-voting-history from Toolforge GridEngine to Toolforge Kubernetes
		Open		dcaro	T194332 [Epic] Make Toolforge a proper platform as a service with push-to-deploy and build packs
		In Progress		dcaro	T267374 [tbs.beta] Create a toolforge build service beta release
		Resolved		Raymond_Ndibe	T316332 [tbs.buildpack-admission-controller] Ensure we use the deploy.sh standard

Event Timeline

dcaro triaged this task as High priority.Aug 26 2022, 9:57 AM

dcaro created this task.

dcaro added a project: Toolforge Build Service.

dcaro added a parent task: T267374: [tbs.beta] Create a toolforge build service beta release.Aug 26 2022, 9:57 AM

Raymond_Ndibe claimed this task.Aug 29 2022, 10:16 PM

Raymond_Ndibe added a project: User-Raymond_Ndibe.

This can build on top of https://github.com/toolforge/buildpack-admission-controller/pull/6 that improves some of the scripts, but it's not really needed.

KHernandez-WMF set the point value for this task to 5.Aug 31 2022, 5:49 PM

KHernandez-WMF moved this task from Backlog to Discussed/Estimated on the Toolforge Build Service board.

KHernandez-WMF moved this task from Discussed/Estimated to Iteration 00 on the Toolforge Build Service board.

KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 00); removed Toolforge Build Service.

Raymond_Ndibe moved this task from Backlog to In Progress on the User-Raymond_Ndibe board.Sep 9 2022, 7:01 PM

Raymond_Ndibe moved this task from In Progress to In Review on the User-Raymond_Ndibe board.Sep 13 2022, 7:49 PM

Raymond_Ndibe moved this task from Next Up to In Review on the Toolforge Build Service (Iteration 00) board.Sep 13 2022, 7:51 PM

Manually linking the patch https://github.com/toolforge/buildpack-admission-controller/pull/7

dcaro moved this task from Iteration 00 to Iteration 01 on the Toolforge Build Service board.Sep 27 2022, 8:26 AM

dcaro edited projects, added Toolforge Build Service (Iteration 01); removed Toolforge Build Service (Iteration 00).

• bd808 moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.Sep 27 2022, 9:24 PM

Raymond_Ndibe moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 01) board.Oct 3 2022, 9:30 PM

Raymond_Ndibe closed this task as Resolved.Oct 11 2022, 1:15 PM

Raymond_Ndibe moved this task from In Progress to Done on the Toolforge Build Service (Iteration 01) board.

In T316332#8249491, @Raymond_Ndibe wrote:

Manually linking the patch https://github.com/toolforge/buildpack-admission-controller/pull/7

That patch is not yet reviewed/merged, the task should not be closed right?