Page MenuHomePhabricator

Adyen iDeal code seems to go through DirectDebitPaymentProvider
Closed, ResolvedPublic

Description

I noticed when debugging an Adyen iDeal non-recurring transaction, the code went down the path of using the DirectDebitPaymentProvider and calling createDirectDebitPaymentFromCheckout here, even though this is a non-recurring non-direct-debit transaction. Everything appears to work, but I don't think an iDeal bank transfer one-off should live here as it's not using a direct debit to make the payment.

Maybe there's an explanation?

Event Timeline

Ah, this was my mistake I guess. I wasn't clear on the distinction between direct debit and whatever-ideal-is. If you want to rename the class please go ahead.

err, sorry, cstone wrote this, but I thought it was right too!

Yeah same I just thought iDEAL was a type of direct debit. +1 to renaming it whatever it actually is.

Change 833056 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] Update the ideal non recurring payment function name from direct Debit to ideal

https://gerrit.wikimedia.org/r/833056

Change 833056 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Update adyen class name from DirectDebit to IdealBankTransfer and function name from createDirectDebitPaymentFromCheckout to createIdealNonRecurringPaymentFromCheckout for easy understanding

https://gerrit.wikimedia.org/r/833056