Page MenuHomePhabricator
Create Task
Maniphest T316393

Disable all patrolling functions on de.wikipedia
Open, Needs TriagePublic
Actions

Description

follow up declined task T102818

Please deactivate
$wgUseFilePatrol and $wgUseNPPatrol on de.wikipedia as there is a new situation:

Patrol buttons are already hidden via https://de.wikipedia.org/wiki/MediaWiki:Common.css and https://de.wikipedia.org/wiki/MediaWiki:Mobile.css after discussion. I have not seen any objections that admins or other groups would still need this function since february 2021.

see also T100682

In T100682#1375476, @Tgr wrote:
In T100682#1320701, @Steinsplitter wrote:

I personally think that switching off patrolmarks on dewiki completely makes moor sense because it is defacto not in use and just creating unnecessary logentry's.

Indeed. Why not just set [[ https://www.mediawiki.org/wiki/Manual:$wgUseRCPatrol | $wgUseRCPatrol ]] / [[ https://www.mediawiki.org/wiki/Manual:$wgUseNPPatrol | $wgUseNPPatrol ]] to false? That's how FlagRev is used on the Hungarian Wikipedia and we had no problems with it.

See also projects that have already deactivated patrol buttons in InitialiseSettings.php:

'wgUseNPPatrol' => [
	'default' => true, // brion 2007-11-16
	'fishbowl' => false, // T74239
	'private' => false, // T74239
	'huwiki' => false, // T21241
	'ruwiki' => false, // T33650
	'sqwiki' => false, // T27822
	'ukwiki' => false, // T35273
	'bswiki' => false, // T158662
],

'wgUseFilePatrol' => [
	'default' => true,
	'huwiki' => false, // T21241
	'ruwiki' => false, // T154285
	'bswiki' => false, // T158662
],

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
dewiki: Trun off patrollingoperations/mediawiki-configmaster+11 -3
Customize query in gerrit

Related Objects

Event Timeline

Wnme created this task.Aug 26 2022, 6:23 PM
Restricted Application added subscribers: Base, Aklapper. · View Herald TranscriptAug 26 2022, 6:23 PM
Wnme added a comment.EditedAug 26 2022, 6:23 PM

Is it also possible to remove all configurations related to patrol function on de.wikipedia?:

Wnme added subscribers: XanonymusX, hgzh.Aug 26 2022, 6:31 PM
XenonX3 subscribed.Aug 26 2022, 6:39 PM
Raymond subscribed.Aug 26 2022, 7:17 PM
Aklapper added a comment.Aug 27 2022, 3:33 AM

@Wnme: Is there an on-wiki discussion / community consensus for this? Please see https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes

Johannnes89 subscribed.Aug 27 2022, 6:49 AM
XanonymusX added a comment.Aug 27 2022, 7:52 AM

The latest one was this one. A broader community discussion is not to be expected, considering that basically nobody knows about this feature.

Wnme added a comment.EditedAug 27 2022, 8:01 AM

@Aklapper To be honest, I don't see that this is a change in the sense of the instructions. So the presence of Patrol in Special:Log only irritates.

The functions are already unusable due to the described changes of local css and were not actually used before. So this is just a matter of maintenance and tidying up. In fact, no functions are being changed, and nothing is being taken away from the community. See also the argumentation in previous T102818. I actually already saw a clear state of discussion on deactivation there.

Peachey88 updated the task description. (Show Details)Aug 27 2022, 8:23 AM
gerritbot added a comment.Aug 30 2022, 5:32 PM

Change 828061 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] dewiki: Trun off patrolling

https://gerrit.wikimedia.org/r/828061

gerritbot added a project: Patch-For-Review.Aug 30 2022, 5:32 PM
Stang claimed this task.Sep 1 2022, 12:08 AM
Stang subscribed.

As sysop permission is needed to test this patch, I would like a sysop, for example the author of this task, to test this by themselves during a backport window. If you need any help of this, you could leave a message on my talk page on any Wikimedia site.

Stang added a comment.Sep 7 2022, 8:27 PM

@Wnme I see you are currently an admin on dewiki, would you like to test this change by yourself?

Wnme added a comment.Sep 9 2022, 5:32 PM

Thanks a lot @Stang for the patch! I'll have a deeper look in next few days.

Wnme added a comment.Sep 24 2022, 8:10 AM

Hi @Stang I forgot to mention it in the task. But the reason for this was a discussion why the patroll log is displayed on dewiki. Do you see an option to disable this as well? Manual:$wgLogTypes and Manual:Log actions may be helpful.

Stang added a subscriber: Urbanecm.Oct 13 2022, 7:39 PM

When setting wgUseNPPatrol and wgUseFilePatrol to false, user could still access "Special:log/patrol". Yes, if you remove "patrol" from the $wgLogTypes array mentioned above, user could no longer search that, but I wonder if it will cause some problems, like we should not hide that entry point, and if it could cause some other issue when accessing some other types of logs. @Urbanecm would you like to have a look at this one and give your advice? Thanks!

Wnme added a comment.Dec 22 2022, 10:25 PM

Hi @Urbanecm Friendly reminder. There was a question for you here.

Johannnes89 added a comment.May 25 2023, 7:09 AM

Any news on this task? I noticed a couple of days ago that the markpatrolled-button still appears for a few of seconds when visiting new pages on mobile browser even though we tried to hide it. We really don't use the patrolled function and it should be disabled.

Xaosflux mentioned this in T356044: Avoid the possibility to give the interface-admin rights to users without autopatrolled rights.Feb 29 2024, 2:17 PM
gerritbot added a comment.Jun 23 2024, 10:37 AM

Change #828061 abandoned by Stang:

[operations/mediawiki-config@master] dewiki: Trun off patrolling

Reason:

no longer work on this, someone else could take it

https://gerrit.wikimedia.org/r/828061

Stang removed Stang as the assignee of this task.Jun 23 2024, 10:37 AM
Stang edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits