Page MenuHomePhabricator
Create Task
Maniphest T316394

[M] Quick view - Add the article title and wikidata description to quick view for extra context
Closed, ResolvedPublic
Actions

Assigned To
SimoneThisDot
Authored By
Sneha
Aug 26 2022, 6:46 PM
Tags
Referenced Files
F35967929: Screen Shot 2023-01-03 at 10.47.19 AM.png
Jan 3 2023, 6:57 PM
F35690036: spacing fixes.png
Nov 1 2022, 1:51 PM
F35686163: Screen Shot 2022-10-31 at 3.21.49 PM.png
Oct 31 2022, 11:05 PM
F35491979: Special_Search (22).png
Aug 26 2022, 6:46 PM
Subscribers
Aklapper
CBogen
Etonkovidova
• EUdoh-WMF
Sneha

Description

This ticket is to add the article title and wiki data description to give users some context on which article they are referring to and also learn what the article is about. The short description helps with cases when the snippet is not from the first sentence or paragraph of the article.

Acceptance Criteria:

  • Add the article title in blue
  • The article title should link to the main article.
  • Add wiki data short description of the article below it.
  • If the wiki data description does not exist leave the description blank. (A fall back option for showing article intro text is covered in T316395)

Link to details specs in Figma

Special_Search (22).png (1×1 px, 275 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/SearchVuemaster+2 -2Add the article title and description to quick view for extra context
mediawiki/extensions/SearchVuemaster+128 -9Add the article title and wikidata description to quick view for extra context
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sneha created this task.Aug 26 2022, 6:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2022, 6:46 PM
CBogen added a project: SDAW-Search-Improvements (Milestone 2: QuickView MVP).Aug 26 2022, 6:50 PM
Sneha mentioned this in T316395: [M] Quick view - Show article intro in quick view when wiki data description does not exist..Aug 26 2022, 6:57 PM
Sneha updated the task description. (Show Details)
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Aug 29 2022, 4:39 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
CBogen renamed this task from Quick view - Add the article title and wikidata description to quick view for extra context to [M] Quick view - Add the article title and wikidata description to quick view for extra context.Sep 21 2022, 4:47 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Sep 21 2022, 5:02 PM
SimoneThisDot changed the task status from Open to In Progress.Sep 27 2022, 8:21 PM
SimoneThisDot claimed this task.
SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
SimoneThisDot added a comment.Sep 27 2022, 8:45 PM

@Sneha can you please clarify that in this AC:

If the wiki data description does not exist do not show anything.

When you say "do not show anything", you actually are referring to the Description, but you still would like to show the title in the absence of a description

Sneha added a comment.Sep 27 2022, 11:10 PM

Yes when I say "do not show anything" I am referring to no description. Title would still be there. I will update in the ticket.

Sneha updated the task description. (Show Details)Sep 27 2022, 11:11 PM
gerritbot added a comment.Sep 28 2022, 2:45 PM

Change 836234 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Add the article title and wikidata description to quick view for extra context

https://gerrit.wikimedia.org/r/836234

gerritbot added a project: Patch-For-Review.Sep 28 2022, 2:45 PM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Sep 29 2022, 7:40 AM
gerritbot added a comment.Oct 4 2022, 8:55 AM

Change 836234 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Add the article title and wikidata description to quick view for extra context

https://gerrit.wikimedia.org/r/836234

matthiasmullie mentioned this in rESVU07032be4e712: Add the article title and wikidata description to quick view for extra context.Oct 4 2022, 8:56 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 4 2022, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2022, 9:30 AM
Seddon moved this task from Code Review to Blocked on the Structured-Data-Backlog (Current Work) board.Oct 4 2022, 10:26 AM
Seddon added a subscriber: Seddon.

Blocked awaiting release on beta cluster for testing

CBogen moved this task from Blocked to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 19 2022, 2:54 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 31 2022, 11:05 PM
Etonkovidova added a subscriber: Etonkovidova.

Checked on enwiki betalabs (https://en.wikipedia.beta.wmflabs.org/w/index.php?search=cat&title=Special:Search&profile=advanced&fulltext=1&ns0=1&quickView=Asian+golden+cat)

Screen Shot 2022-10-31 at 3.21.49 PM.png (942×1 px, 536 KB)

Testing notes:
The following spec should be checked in production:

  • Add wiki data short description of the article below it.

Running the above search - https://en.wikipedia.beta.wmflabs.org/w/index.php?search=cat&title=Special:Search&profile=advanced&fulltext=1&ns0=1&quickView=Cat, I looked at the first article returned by the search: https://en.wikipedia.beta.wmflabs.org/wiki/Cat
The article lists Q598520 as wikidata item ID on Cat Page information, but the description that was displayed was Local description, not Central description.

Etonkovidova updated the task description. (Show Details)Oct 31 2022, 11:05 PM
Sneha added a comment.Nov 1 2022, 1:51 PM

I also want to note that the spacing around the (Title+wikidata) description is not uniform to what we show between other sections. The pink space is wider than the green space.

spacing fixes.png (942×1 px, 496 KB)

CBogen moved this task from Verify on Production to Doing on the Structured-Data-Backlog (Current Work) board.Nov 1 2022, 3:41 PM
CBogen added a subscriber: CBogen.

@SimoneThisDot moving this back to Doing to check that the wikidata description is coming from the right place and to fix the padding.

SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Nov 8 2022, 9:57 PM

I have created a patch to update the padding and also confirmed with Elena on the description used.

NOTE: The cat image has a white border at the bottom! So the padding are now right, but they may look off if searching for cat! :)
gerritbot added a comment.Nov 9 2022, 8:35 AM

Change 854948 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Add the article title and description to quick view for extra context

https://gerrit.wikimedia.org/r/854948

gerritbot added a project: Patch-For-Review.Nov 9 2022, 8:35 AM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Nov 10 2022, 3:10 PM
gerritbot added a comment.Nov 10 2022, 3:15 PM

Change 854948 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Add the article title and description to quick view for extra context

https://gerrit.wikimedia.org/r/854948

SimoneThisDot mentioned this in rESVU27593575c1d3: Add the article title and description to quick view for extra context.Nov 10 2022, 3:15 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 10 2022, 3:30 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Nov 10 2022, 4:00 PM
• EUdoh-WMF added a subscriber: • EUdoh-WMF.Nov 20 2022, 11:36 PM

Hi @SimoneThisDot, I take it the Local Description is what is being used and not the Central Description?

Seddon removed a subscriber: Seddon.Nov 29 2022, 4:23 PM
CBogen added a comment.Dec 8 2022, 7:46 PM
In T316394#8408257, @EUdoh-WMF wrote:

Hi @SimoneThisDot, I take it the Local Description is what is being used and not the Central Description?

@SimoneThisDot following up on this, thanks!

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 3 2023, 6:57 PM
In T316394#8381388, @SimoneThisDot wrote:

I have created a patch to update the padding and also confirmed with Elena on the description used.

NOTE: The cat image has a white border at the bottom! So the padding are now right, but they may look off if searching for cat! :)

(1) Checked in betalabs - the fix is in place

BeforeAfter the fix
Screen Shot 2022-10-31 at 3.21.49 PM.png (942×1 px, 536 KB)
the distance between elements - the header and description etc - is about 33-35px
Screen Shot 2023-01-03 at 10.47.19 AM.png (1×722 px, 844 KB)

(2) Re Local Description vs Central Description - more examples in T325831: [QA task] Special:Search quick preview - local vs central description . It could be a no-issue, but the requirement below seems not to be followed in some cases. I linked this task to T325831.

  • Add wiki data short description of the article below it.

Moving to Verify on Production.

Etonkovidova added a subtask: T325831: [QA task] Special:Search quick preview - local vs central description .Jan 3 2023, 6:59 PM
Etonkovidova closed this task as Resolved.Jan 10 2023, 1:45 AM
Etonkovidova updated the task description. (Show Details)

Checked on pilot wikis - ruwiki, idwiki, and ptwiki - works as expected.

Etonkovidova closed subtask T325831: [QA task] Special:Search quick preview - local vs central description as Resolved.Feb 2 2023, 9:13 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL