Page MenuHomePhabricator

[M] Quick view - Show article intro in quick view when wiki data description does not exist.
Closed, ResolvedPublic

Description

This ticket is an enhancement to this ticket T316394

Acceptance Criteria:

  • When the wiki data description of the article does not exist show the short article intro. Ideally only the first line of the article to keep it short.
  • Don't show the short article intro if it is the snippet also comes from the article intro
  • This solution is only for Desktop and should not affect or be visible on mobile preview.

Link to detailed spec in Figma

Special_Search (24).png (1×1 px, 357 KB)

Event Timeline

CBogen renamed this task from Quick view - Show article intro in quick view when wiki data description does not exist. to [M] Quick view - Show article intro in quick view when wiki data description does not exist..Jan 11 2023, 5:36 PM

I have a question for you @Sneha what do you mean by short article info?

@SimoneThisDot I meant the first line of the article. Since I don't think we have any field like article intro.

Change 896048 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Quick view - Show article intro in quick view when wiki data description does not exist.

https://gerrit.wikimedia.org/r/896048

Change 896048 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Quick view - Show article intro in quick view when wiki data description does not exist.

https://gerrit.wikimedia.org/r/896048

Checked in betalabs:

Screen Shot 2023-03-30 at 3.43.54 PM.png (1×2 px, 1 MB)

Testing notes

  • in production check this link ptwiki
  • don't change the UI language since the wikidata descriptions fall on the UI lang

@SimoneThisDot - two questions:
(1) there are quite few cases when the following spec is not done:

  • Don't show the short article intro if it is the snippet also comes from the article intro

For example, search=cat&quickView=Bay+cat will show the same article snippet:

Screen Shot 2023-03-30 at 3.41.10 PM.png (1×2 px, 1 MB)

(2) the mobile displays the article intro just as desktop does

desktop betalabsmobile betalabs
Screen Shot 2023-03-30 at 3.43.54 PM.png (1×2 px, 1 MB)
Screen Shot 2023-03-30 at 4.17.36 PM.png (1×740 px, 387 KB)
Screen Shot 2023-03-30 at 3.41.10 PM.png (1×2 px, 1 MB)
Screen Shot 2023-03-30 at 4.17.52 PM.png (942×734 px, 319 KB)

The spec says:

  • This solution is only for Desktop and should not affect or be visible on mobile preview.

Change 904746 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Quick view - Show article intro in quick view when wiki data description does not exist.

https://gerrit.wikimedia.org/r/904746

Hi @Etonkovidova.

Unfortunately both of the above are bugs that managed to fall through the crack. The first was due to the ... added at the end of the snippets and the second was a total mistake on my part.

I have created already a patch to solve this. Not sure if this needs to be moved back to Review or what.. I am going to ping Matthias now for the patch to merge it quickly

Change 904746 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Quick view - Show article intro in quick view when wiki data description does not exist.

https://gerrit.wikimedia.org/r/904746

Hi @Etonkovidova.

Unfortunately both of the above are bugs that managed to fall through the crack. The first was due to the ... added at the end of the snippets and the second was a total mistake on my part.

I have created already a patch to solve this. Not sure if this needs to be moved back to Review or what.. I am going to ping Matthias now for the patch to merge it quickly

Thank you, @SimoneThisDot! Both bugs (1) and (2) are fixed.

To see the short description search on betalabs - search=mountains&quickView=Andean+mountain+cat
The same article - Andean_mountain_cat will be displayed in quick view without a short description if the search is search=cat&quickView=Andean+mountain+cat

Checked in wmf.3 - no issues; the links below present the case when there are no wikidata descriptions: