Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in CheckUser's PreliminaryCheckService
Closed, ResolvedPublic3 Estimated Story Points

Description

See the parent task T312479: Migrate usage of Database::select to SelectQueryBuilder in CheckUser for details.

Acceptance criteria
  • SelectQueryBuilder is used where possible in PreliminaryCheckService
Notes

For more information check T243051 and its documentation.

Event Timeline

Tchanders set the point value for this task to 3.Sep 1 2022, 7:53 PM

Change 830243 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/CheckUser@master] Migrate usage of Database::select to SelectQueryBuilder in CheckUser's PreliminaryCheckService

https://gerrit.wikimedia.org/r/830243

Change 830243 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Migrate usage of Database::select to SelectQueryBuilder in CheckUser's PreliminaryCheckService

https://gerrit.wikimedia.org/r/830243

dom_walden subscribed.

I compared the results returned by the "Account information" tab before and after this change. I did not see any differences.

I also compared the SQL queries being made before and after (by looking at the logs). They were identical.

In case that the data format that newSelectQueryBuilder() returns is different, I checked that it could correctly identify an expired block, by creating a block and waiting for it to expire.

Test environment: local docker CheckUser 2.5 (aea1ef3) 06:33, 20 September 2022.