@Marostegui That looks correct to me.

I can write a dbctl patch today to do this automatically, so you can still manage replicas in dbctl, if that would be helpful.

We'd implement that by adding a new flavor for sections -- I guess call it mainstash? or omit-replicas? -- and then we could set x2 to be that flavor.

In T316482#8193428, @CDanis wrote:

@Marostegui That looks correct to me.

I can write a dbctl patch today to do this automatically, so you can still manage replicas in dbctl, if that would be helpful.

That'd be helpful indeed! Thank you

We'd implement that by adding a new flavor for sections -- I guess call it mainstash? or omit-replicas? -- and then we could set x2 to be that flavor.

omit-replicas looks good to me, so we can re-use it somewhere else if needed (ideally I would like to handle parsercache with dbctl in a future, as they are the only ones still handled with mediawiki-config)

Also, would this solution also work for T245239: dbctl: treat read only ES hosts as standalone hosts?

Thanks!

In T316482#8193431, @Marostegui wrote:

omit-replicas looks good to me, so we can re-use it somewhere else if needed (ideally I would like to handle parsercache with dbctl in a future, as they are the only ones still handled with mediawiki-config)

OK, sounds good!

Also, would this solution also work for T245239: dbctl: treat read only ES hosts as standalone hosts?

Unfortunately not, although I'll do a little thinking about that one while I'm in the code.

Sounds good, thank you @CDanis

Change 828606 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/software/conftool@master] dbctl: Add omit_replicas_in_mwconfig section attribute

https://gerrit.wikimedia.org/r/828606

@Marostegui I actually implemented this not as a new flavor, but instead as a boolean attribute omit_replicas_in_mwconfig on the section object. Once the patch is merged and deployed I'll let you know.

Excellent @CDanis - thank you. Let me know indeed and I can add it to x2.

Change 828606 merged by jenkins-bot:

[operations/software/conftool@master] dbctl: Add omit_replicas_in_mwconfig section attribute

https://gerrit.wikimedia.org/r/828606

Change 828946 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/puppet@production] dbctl: update schema for 2.2.2

https://gerrit.wikimedia.org/r/828946

Change 828946 merged by CDanis:

[operations/puppet@production] dbctl: update schema for 2.2.2

https://gerrit.wikimedia.org/r/828946

Change 828947 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/puppet@production] dbctl: update schema for 2.2.2

https://gerrit.wikimedia.org/r/828947

Change 828947 merged by CDanis:

[operations/puppet@production] dbctl: update schema for 2.2.2

https://gerrit.wikimedia.org/r/828947

This is ready, was tested by hand on cumin2002, and is now deployed to both cumin hosts.

✔️ cdanis@cumin2002.codfw.wmnet ~ 🕗☕ sudo dbctl -s codfw section x2 edit
# edit omit_replicas_in_mwconfig to be true instead of default false

✔️ cdanis@cumin2002.codfw.wmnet ~ 🕗☕ dbctl config diff -u    
--- codfw/externalLoads/x2 live
+++ codfw/externalLoads/x2 generated
@@ -2,8 +2,5 @@
     {
         "db2142": 0
     },
-    {
-        "db2143": 100,
-        "db2144": 100
-    }
+    {}
 ]

✔️ cdanis@cumin2002.codfw.wmnet ~ 🕗☕ sudo dbctl -s codfw section x2 edit
# rolled back omit_replicas_in_mwconfig to be false

Mentioned in SAL (#wikimedia-operations) [2022-09-01T12:20:27Z] <cdanis@cumin2002> dbctl commit (dc=all): 'T316482 remove replicas from x2', diff saved to https://phabricator.wikimedia.org/P33736 and previous config saved to /var/cache/conftool/dbconfig/20220901-122026-cdanis.json